test(web): warm the traces tier in C9 so arm (b) claims at adoption by ryansolid · Pull Request #4461 · solidjs/solid

ryansolid · 2026-10-30T13:07:08Z

Before: the hydrate spec test/consistency/c09-no-phantom.spec.tsx failed in about half of runs on a clean next (12 of 20 runs). The failures showed up as red job CI on unrelated PRs (#4454). Case (b) saw 0 fill invocations, and case (c) sometimes saw a stray "Hydration key miss".

After: the spec passes 25 of 25 runs, and 20 of 20 with every core busy. No assertion changed.

Case (b)'s container-trace arg is materialized by the frames client's traces tier, which loads by dynamic import (tierLoaders.trace). C9 never loaded it ahead of time. So the fill's read found the tier missing and held the occurrence until the import landed, which is the intended cold-load behaviour (pinned by tier-trace-hold.spec.tsx). Two fixed quiesce() rounds can't wait out a module load, so (b) lost that race under load. When (b) lost, its held frame stayed live, and the trace import landing during (c) mounted it against the torn-down DOM. That key miss landed in (c)'s warning spy, which is why (c) only failed alongside (b).

How: beforeAll(() => prepareTier("trace")), the same warm-up C19 and C11 already use, plus a module-doc paragraph saying why. Test-only; no runtime source changed.

Generated by Claude Code

C9 (b) reads a container-trace arg, whose materializer is the frames client's traces tier (plan step C3, `tierLoaders.trace`, a dynamic import). The spec never warmed it, so the marker held the occurrence (frame-client.ts `needsTrace`) until the import landed, a module load that two fixed `quiesce()` rounds only sometimes outlast. When it lost, (b) saw no fill, and the orphaned held frame then mounted on the late install's flush during (c), logging (b)'s key miss into (c)'s page. Warm it once in `beforeAll`, as C19 and C11 do; the cold hold keeps its own pin (tier-trace-hold.spec). Assertions unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

changeset-bot · 2026-10-30T13:07:15Z

⚠️ No Changeset found

Latest commit: 3842776

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-30T13:10:29Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	+13 B	7.43 KB	✅
signals: + createStore	14.93 KB	0 B	14.95 KB	✅
signals: + isPending/latest	11.08 KB	+3 B	11.10 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.04 KB	+13 B	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.78 KB	+13 B	9.78 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.75 KB	+13 B	18.74 KB	⚠️ over by 5 B, 7 B minified headroom	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.42 KB	+19 B	32.45 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.45 KB	0 B	13.47 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.20 KB	+13 B	15.20 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.76 KB	0 B	29.78 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.96 KB	+13 B	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.29 KB	0 B	26.31 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.51 KB	0 B	32.52 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.70 KB	+13 B	33.66 KB	⚠️ over by 45 B, 7 B minified headroom	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.03 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	38.75 KB	+80 B	38.76 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.03 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.63 KB	+13 B	35.66 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 8.99 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	42.67 KB	+4 B	42.71 KB	✅	eager (counted): web.js 22.75 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.07 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.20 KB	+13 B	41.23 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.03 KB, serverForms.js 3.57 KB, trace.js 9.02 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.31 KB	+5 B	48.44 KB	✅	eager (counted): client.js 27.86 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.00 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	0 B	1.29 KB	✅
server: renderToString (the server-render floor)	22.79 KB	0 B	22.80 KB	✅

⚠️ Over the brotli cap within the minified allowance (passes)

app: hydrating (no stores) with Show/For/Loading/Errored/lazy: over brotli cap by 5 B; minified 53,598 B vs 53,585 B recorded with the cap (+13 B) — 7 B of the 20 B minified allowance left; +0 B minified over this PR's base
page: base server components (hydrating + dynamic + frames + sf reference): over brotli cap by 45 B; minified 101,618 B vs 101,605 B recorded with the cap (+13 B) — 7 B of the 20 B minified allowance left; +0 B minified over this PR's base

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-10-30T13:19:16Z

Coverage Report for CI Build 41060593170

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 78.1%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1362
Covered Lines:	1125
Line Coverage:	82.6%
Relevant Branches:	1090
Covered Branches:	790
Branch Coverage:	72.48%
Branches in Coverage %:	Yes
Coverage Strength:	29.82 hits per line

💛 - Coveralls

codspeed · 2026-10-30T13:23:27Z

Merging this PR will not alter performance

1 warning

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 200 untouched benchmarks
⏩ 5 skipped benchmarks¹

_{Comparing claude/project-thread-x1ore2-c09-flake (3842776) with next (9c4e4a8)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ryansolid merged commit 563b6b0 into next Oct 30, 2026
9 checks passed

Navigation Menu

Repository navigation

test(web): warm the traces tier in C9 so arm (b) claims at adoption - #4461

test(web): warm the traces tier in C9 so arm (b) claims at adoption#4461
ryansolid merged 1 commit into
nextfrom
claude/project-thread-x1ore2-c09-flake

ryansolid commented Oct 30, 2026

Uh oh!

changeset-bot Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

coveralls commented Oct 30, 2026

Uh oh!

codspeed Bot commented Oct 30, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 30, 2026

Uh oh!

changeset-bot Bot commented Oct 30, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 30, 2026

Size (brotli, eager entry chunk)

⚠️ Over the brotli cap within the minified allowance (passes)

Uh oh!

coveralls commented Oct 30, 2026

Coverage Report for CI Build 41060593170

Coverage remained the same at 78.1%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

codspeed Bot commented Oct 30, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants