chore(size): re-record the ledger after the 2026-10-30 merges by ryansolid · Pull Request #4462 · solidjs/solid

ryansolid · 2026-10-30T13:30:42Z

Before: on next @ 563b6b0, two scenarios fail the size gate: signals: + createStore is 14,951 B brotli against a 14.95 KB cap and 36 B minified over its record, and app: compiled CSR is 26,312 B against 26.31 KB, also +36 B minified. #4454 and #4457 each passed against their own base, but together they cross both caps. Every PR opened against next would fail these two scenarios.

After: both caps are raised by the cap rule (measured + 10 B, rounded up to 0.01 KB): createStore 14.97 KB / 43,924, compiled CSR 26.33 KB / 80,035. The recorded minified of every other non-frozen scenario that moved is set to its measured value, with caps unchanged. The hydrating + stores scenario drops by 302 B.

How: scripts/size/scenarios.js only, with a one-line ledger comment per scenario. No frozen floor is touched (floor-caps.json unchanged). Brotli growth over the two raised caps is +1 B and +2 B; the minified growth is #4454's stagedScreen check and #4457's same-error skip.

Generated by Claude Code

createStore and the compiled CSR app were over their caps on next after #4454 and #4457 landed together; raise both by the cap rule and re-record the minified of every non-frozen scenario that moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

changeset-bot · 2026-10-30T13:30:50Z

⚠️ No Changeset found

Latest commit: 077ae6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-30T13:33:53Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	+13 B	7.43 KB	✅
signals: + createStore	14.95 KB	0 B	14.97 KB	✅
signals: + isPending/latest	11.09 KB	0 B	11.10 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.04 KB	0 B	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.78 KB	+13 B	9.78 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.75 KB	+13 B	18.74 KB	⚠️ over by 5 B, 7 B minified headroom	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.37 KB	0 B	32.45 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.45 KB	0 B	13.47 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.18 KB	0 B	15.20 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.76 KB	0 B	29.78 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.96 KB	0 B	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.31 KB	0 B	26.33 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.47 KB	0 B	32.52 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.76 KB	0 B	33.77 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.02 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	38.82 KB	0 B	38.83 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.02 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.70 KB	0 B	35.72 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 8.99 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	42.70 KB	0 B	42.71 KB	✅	eager (counted): web.js 22.77 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.06 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.18 KB	0 B	41.23 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.03 KB, serverForms.js 3.57 KB, trace.js 9.02 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.37 KB	0 B	48.44 KB	✅	eager (counted): client.js 27.91 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.01 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	0 B	1.29 KB	✅
server: renderToString (the server-render floor)	22.79 KB	0 B	22.80 KB	✅

⚠️ Over the brotli cap within the minified allowance (passes)

app: hydrating (no stores) with Show/For/Loading/Errored/lazy: over brotli cap by 5 B; minified 53,598 B vs 53,585 B recorded with the cap (+13 B) — 7 B of the 20 B minified allowance left; +0 B minified over this PR's base

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-10-30T13:39:11Z

Coverage Report for CI Build 41063860524

Coverage remained the same at 78.1%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1362
Covered Lines:	1125
Line Coverage:	82.6%
Relevant Branches:	1090
Covered Branches:	790
Branch Coverage:	72.48%
Branches in Coverage %:	Yes
Coverage Strength:	29.7 hits per line

💛 - Coveralls

codspeed · 2026-10-30T13:55:31Z

Merging this PR will improve performance by 9.94%

2 warnings

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
✅ 199 untouched benchmarks
⏩ 5 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`arrow in template`	11.9 ms	10.8 ms	+9.94%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/project-thread-x1ore2-ledger-563b6b0 (077ae6d) with next (563b6b0)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ryansolid merged commit cddaa76 into next Oct 30, 2026
8 checks passed

This was referenced Oct 30, 2026

fix(signals): a merged transaction's verdict lane is the same hold's at the D-28 seat (#4427) #4455

Merged

fix(signals): a first answer landing in the tick a write re-asks it is answered, then re-asked (D-22, F-9) #4459

Merged

Navigation Menu

Repository navigation

chore(size): re-record the ledger after the 2026-10-30 merges - #4462

chore(size): re-record the ledger after the 2026-10-30 merges#4462
ryansolid merged 1 commit into
nextfrom
claude/project-thread-x1ore2-ledger-563b6b0

ryansolid commented Oct 30, 2026

Uh oh!

changeset-bot Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

coveralls commented Oct 30, 2026

Uh oh!

Uh oh!

codspeed Bot commented Oct 30, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 30, 2026

Uh oh!

changeset-bot Bot commented Oct 30, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 30, 2026

Size (brotli, eager entry chunk)

⚠️ Over the brotli cap within the minified allowance (passes)

Uh oh!

coveralls commented Oct 30, 2026

Coverage Report for CI Build 41063860524

Coverage remained the same at 78.1%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

Uh oh!

codspeed Bot commented Oct 30, 2026

Merging this PR will improve performance by 9.94%

Performance Changes

Footnotes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants