chore(size): re-record the ledger after the 2026-10-30 batch (#4473, #4475, #4478, #4459) by ryansolid · Pull Request #4501 · solidjs/solid

ryansolid · 2026-10-30T19:37:05Z

Before: next @ 643a7a7 is over four caps after the batch merged. The fix PRs carried no ledger edits, per the batch process. Every open PR's size check fails on those four rows whatever its own diff does.

After: the four rows are re-recorded at next's measured size, and next passes the size gate. Scenarios where the batch drifted more than 20 B minified under an unchanged cap get their recorded minified reset too, so the next PRs' minified deltas are judged against the real base.

Measured over next @ 643a7a7 (linux), brotli / minified:

Scenario	Cap	Recorded minified
signals: + isPending/latest	11.19 → 11.29 KB (11,271 B)	30,840 → 31,101
page: live server components (frozen floor)	38.91 → 38.98 KB (38,969 B)	117,566 → 117,858
page: compiled live server components	42.87 → 42.95 KB (42,931 B)	125,724 → 126,018
page: live + router	48.51 → 48.58 KB (48,569 B)	142,987 → 143,269
app: hydrating + every store primitive family	unchanged	98,463 → 98,535
page: base server components (frozen floor)	unchanged	101,638 → 101,675
page: compiled base server components	unchanged	108,007 → 108,048
page: base + router	unchanged	125,470 → 125,503

Hello world (app: compiled floor) is unchanged at 9,973 B, 7 B under its 9.98 KB cap and 27 B under 10,000 B. The simple-app floor stays over its brotli cap by 8 B within its minified allowance (+15 B), as on next. It is not re-recorded.

The batch's verdict-engine growth comes from #4459 (answered-then-reasked serve, D-22) and #4473 (held-frame leaf, E2), on top of #4475 and #4478. Store-free floors and hello world are untouched.

Size-Exception: the live server-components floor carries the 2026-10-30 batch (#4473, #4475, #4478, #4459; correctness fixes under D-22, D-25, D-30, E2). Its cap goes 38.91 → 38.98 KB and its recorded minified 117,566 → 117,858. The base server-components floor's recorded minified goes 101,638 → 101,675 with its cap unchanged.

Generated by Claude Code

…4475, #4478, #4459) Next @ 643a7a7 sits over four caps after the batch merged back to back (each fix PR carried no ledger edits, per the batch process). Re-records, measured over next @ 643a7a7 (linux): - signals: + isPending/latest: 11.19 -> 11.29 KB, minified 30,840 -> 31,101 - page: live server components (frozen floor): 38.91 -> 38.98 KB, minified 117,566 -> 117,858 - page: compiled live server components: 42.87 -> 42.95 KB, minified 125,724 -> 126,018 - page: live + router: 48.51 -> 48.58 KB, minified 142,987 -> 143,269 and the recorded minified only (caps unchanged) where the batch drifted more than 20 B: hydrating + every store (98,463 -> 98,535), base server components (frozen, 101,638 -> 101,675), compiled base server components (108,007 -> 108,048), base + router (125,470 -> 125,503). Hello world is unchanged at 9,973 B (cap 9.98 KB). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

changeset-bot · 2026-10-30T19:37:13Z

⚠️ No Changeset found

Latest commit: 3f0364d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-30T19:40:08Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.41 KB	+15 B	7.43 KB	✅
signals: + createStore	14.96 KB	+6 B	14.97 KB	✅
signals: + isPending/latest	11.27 KB	0 B	11.29 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.05 KB	+2 B	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.79 KB	+15 B	9.78 KB	⚠️ over by 8 B, 5 B minified headroom
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.72 KB	0 B	18.74 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.47 KB	0 B	32.48 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.45 KB	+9 B	13.47 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.19 KB	+9 B	15.20 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.76 KB	+9 B	29.78 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.97 KB	+2 B	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.27 KB	+13 B	26.33 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.48 KB	+7 B	32.54 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.73 KB	0 B	33.77 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.10 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	38.97 KB	0 B	38.98 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.11 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.66 KB	0 B	35.72 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.06 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	42.93 KB	0 B	42.95 KB	✅	eager (counted): web.js 22.95 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.08 KB, sc-comments.js 0.19 KB, trace.js 9.09 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.13 KB	0 B	41.25 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.03 KB, serverForms.js 3.59 KB, trace.js 9.06 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.57 KB	0 B	48.58 KB	✅	eager (counted): client.js 28.07 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.06 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	0 B	1.29 KB	✅
server: renderToString (the server-render floor)	22.79 KB	0 B	22.80 KB	✅

⚠️ Over the brotli cap within the minified allowance (passes)

app: render + one signal (the simple-app floor): over brotli cap by 8 B; minified 26,754 B vs 26,739 B recorded with the cap (+15 B) — 5 B of the 20 B minified allowance left; +0 B minified over this PR's base

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-10-30T19:48:47Z

Coverage Report for CI Build 41116719714

Coverage remained the same at 78.1%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1362
Covered Lines:	1125
Line Coverage:	82.6%
Relevant Branches:	1090
Covered Branches:	790
Branch Coverage:	72.48%
Branches in Coverage %:	Yes
Coverage Strength:	29.88 hits per line

💛 - Coveralls

codspeed · 2026-10-30T20:02:42Z

Merging this PR will degrade performance by 1.33%

2 warnings

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 198 untouched benchmarks
⏩ 5 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`memo + sync render effect only (reference)`	32.3 ms	35 ms	-7.61%
⚡	`arrow in template`	11.5 ms	10.9 ms	+5.39%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/project-thread-x1ore2-ledger-643a (3f0364d) with next (643a7a7)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ryansolid merged commit 14a8190 into next Oct 30, 2026
8 checks passed

Navigation Menu

Repository navigation

chore(size): re-record the ledger after the 2026-10-30 batch (#4473, #4475, #4478, #4459) - #4501

chore(size): re-record the ledger after the 2026-10-30 batch (#4473, #4475, #4478, #4459)#4501
ryansolid merged 1 commit into
nextfrom
claude/project-thread-x1ore2-ledger-643a

ryansolid commented Oct 30, 2026

Uh oh!

changeset-bot Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

Uh oh!

coveralls commented Oct 30, 2026

Uh oh!

codspeed Bot commented Oct 30, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 30, 2026

Uh oh!

changeset-bot Bot commented Oct 30, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 30, 2026

Size (brotli, eager entry chunk)

⚠️ Over the brotli cap within the minified allowance (passes)

Uh oh!

Uh oh!

coveralls commented Oct 30, 2026

Coverage Report for CI Build 41116719714

Coverage remained the same at 78.1%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

codspeed Bot commented Oct 30, 2026

Merging this PR will degrade performance by 1.33%

Performance Changes

Footnotes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants