Skip to content

chore(size): re-record the ledger after the 2026-10-31 batch (#4519, #4523, #4450, #4522) - #4528

Merged
ryansolid merged 1 commit into
nextfrom
claude/project-thread-x1ore2-ledger-ab3e844
Oct 31, 2026
Merged

ryansolid merged 1 commit into
nextfrom
claude/project-thread-x1ore2-ledger-ab3e844

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Before: next @ ab3e844 has two rows over their brotli caps. Compiled base server components is 8 B over its cap and 35 B minified over its record, so the size gate fails on next. Compiled hydrating is 2 B over, within its minified allowance. Four more rows are more than 20 B minified past the ledger, or close to it.

After: the ledger records next's sizes after the batch, and every row passes the gate.

How: I measured next @ ab3e844 locally. Caps are measured brotli + 10 B, rounded up to 0.01 KB. Rows that are only past the minified allowance re-record minified and keep their caps. The local size.mjs gate passes with this ledger.

Row Cap Recorded minified
page: compiled base SC 35.72 → 35.74 KB 108,081 → 108,116 (+35)
app: compiled hydrating 32.54 → 32.56 KB 100,868 → 100,886 (+18)
app: hydrating + every store unchanged 32.51 KB 98,648 → 98,706 (+58, mostly #4522)
page: base SC (frozen) unchanged 33.81 KB 101,710 → 101,740 (+30)
app: compiled CSR unchanged 26.36 KB 80,106 → 80,127 (+21)
signals: + createStore unchanged 14.99 KB 43,980 → 43,999 (+19)

Brotli on the two raised rows moved +44 B and +38 B over the last ledger, against +18 and +35 B minified. Most of that is mangle layout. Hello world is unchanged at 9,788 B, under its 9.80 KB cap.

Size-Exception: frozen floor "page: base server components" re-records its minified size only (+30 B, from the batch's store changes in #4519 and #4522, both merged with the maintainer's go on 2026-10-31); its cap is unchanged.


Generated by Claude Code

@changeset-bot

changeset-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3f304b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown

Size (brotli, eager entry chunk)

scenario head vs base minified vs base minified vs recorded cap lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush) 7.41 KB 0 B 0 B −3 B 7.43 KB ✅
signals: + createStore 14.92 KB 0 B 0 B 0 B 14.99 KB ✅
signals: + isPending/latest 11.38 KB 0 B 0 B 0 B 11.40 KB ✅
signals: + until/refresh (truth readers, no optimism) 8.04 KB 0 B 0 B −1 B 8.06 KB ✅
app: render + one signal (the simple-app floor) 9.79 KB 0 B 0 B −3 B 9.80 KB ✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy 18.78 KB 0 B 0 B 0 B 18.80 KB ✅ lazy-page.js 0.04 KB
app: hydrating + every store primitive family 32.48 KB 0 B 0 B 0 B 32.51 KB ✅ lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy 13.43 KB 0 B 0 B +13 B 13.47 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the observe artifacts) 15.18 KB 0 B 0 B +13 B 15.20 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled 29.78 KB 0 B 0 B 0 B 29.80 KB ✅ lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click) 9.98 KB 0 B 0 B −1 B 9.98 KB ✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store) 26.31 KB 0 B 0 B 0 B 26.36 KB ✅ stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable) 32.54 KB 0 B 0 B 0 B 32.56 KB ✅ stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec) 11.75 KB 0 B 0 B 0 B 11.77 KB ✅
page: base server components (hydrating + dynamic + frames + sf reference) 33.75 KB 0 B 0 B 0 B 33.81 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.20 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest) 39.08 KB 0 B 0 B +16 B 39.10 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.20 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread) 35.73 KB 0 B 0 B 0 B 35.74 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.16 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest) 43.04 KB 0 B 0 B 0 B 43.06 KB ✅ eager (counted): web.js 23.02 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.19 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate) 41.21 KB 0 B 0 B −25 B 41.25 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.14 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate) 48.68 KB 0 B 0 B 0 B 48.69 KB ✅ eager (counted): client.js 28.16 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.14 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer) 1.27 KB 0 B 0 B 0 B 1.29 KB ✅
server: renderToString (the server-render floor) 22.85 KB 0 B 0 B 0 B 22.87 KB ✅

Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 41179610719

Coverage remained the same at 78.158%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1364
Covered Lines: 1127
Line Coverage: 82.62%
Relevant Branches: 1090
Covered Branches: 791
Branch Coverage: 72.57%
Branches in Coverage %: Yes
Coverage Strength: 29.93 hits per line

💛 - Coveralls

@ryansolid
ryansolid merged commit 41824d4 into next Oct 31, 2026
8 checks passed
@codspeed

codspeed Bot commented Oct 31, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 12.42%

2 warnings

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
✅ 199 untouched benchmarks
⏩ 5 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ arrow in template 12.4 ms 11 ms +12.42%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/project-thread-x1ore2-ledger-ab3e844 (3f304b2) with next (d815fd4)2

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on next (ab3e844) during the generation of this report, so d815fd4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants