Build pull requests from forks and run CI weekly on main - #767
Merged
Merged
Conversation
The workflow only runs on push, so pull requests from forks never get CI results. Travis CI built them by default before the migration to GitHub Actions. Add the pull_request trigger, but skip it when the head branch lives in this repository: those branches are already built on push, so the matrix would otherwise run twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gemfile.lock is not committed, so a new dependency release can break the build while main stays unchanged. The json 3.0 release did exactly that: it broke the Rails 7.x jobs on main (see splitrb#766), but no push to main has happened since, so CI never showed it. Add a weekly scheduled run so such breakage shows up without waiting for the next push. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andrehjr
approved these changes
Sep 27, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small CI trigger changes, split into separate commits so either can be dropped.
1. Build pull requests opened from forks (29f114d)
The workflow only runs on
push, so pull requests from forks never get CI results (e.g. #727, #745, #765, #766). Travis CI built pull requests by default before the migration to GitHub Actions in 2021.This adds the
pull_requesttrigger, but the job is skipped when the head branch lives in this repository. Those branches are already built onpush, so maintainer and Dependabot branches keep running the matrix exactly once, as today. Their PRs just show an extra skippedtestcheck.For fork runs, GitHub passes no secrets and gives a read-only
GITHUB_TOKEN. This workflow uses neither. Depending on the repository's fork PR approval settings, a maintainer may need to approve runs from new contributors.2. Build main weekly (fae801e)
Gemfile.lockis not committed, so a new dependency release can break the build whilemainstays unchanged. json 3.0 did exactly that (see #766), and CI did not show it because nothing had been pushed tomainsince. A weekly run (Mondays 03:00 UTC) surfaces this kind of breakage early.Note: GitHub disables scheduled workflows in public repositories after 60 days without activity. They can be re-enabled from the Actions tab.
Verification
pushbuilds are unchanged. Together with Pin json below 3.0 for the test suite #766, the full matrix passes on my fork: 18/18 jobs.pull_requestrun as intended. I verified this with a temporary PR inside my fork.pull_requestrun started without approval. The failing Rails 7.x job there is the json 3.0 issue fixed by Pin json below 3.0 for the test suite #766, unrelated to this change.🤖 Generated with Claude Code