Repository navigation
Conversation
Pair fresh per-observation pilot evidence with Core feedback for srcfl/ftw#1874. Signed-off-by: Segran <goran@andersson-stehag.se>
segran2
marked this pull request as ready for review
November 6, 2026 23:21
miravoss26
reviewed
Nov 7, 2026
miravoss26
left a comment
There was a problem hiding this comment.
Easee cloud driver 1.5.0: exposes the charger's confirmed pilot current (pilot_a, pilot_observed_at, pilot_confirmed_at_ms) and dynamic_limit_a as separate fields, only when the REST observation was confirmed recently and isn't in the future.
- Correctness, fine:
confirmed_currentrejects NaN, negatives, >80 A, missing source time, stale confirmation (REST_FRESH_MS) and future source times. Whenhost.unix_msis missing it skips the future check and emitspilot_confirmed_at_ms = 0, which the FTW side (#1905) treats as not fresh. That's the safe direction. - Low:
observation_confirmed_msis stamped innote_observationfor any wanted id, including values REST re-confirms unchanged. That's intended (the test name in #1905 says so), but it means "confirmed" = "REST returned it again", not "the charger re-sent it". Worth a comment in the code so nobody reads it as a fresh measurement. - Low:
spec/host-api-profile.jsongains four fields, so anything validating against the profile needs to pick them up. CI is green, so presumably done. - Security screen: no secrets, no new hosts or dependencies, no authz changes.
Safe to merge from my read. It pairs with srcfl/ftw#1905, which consumes these fields. Merge order doesn't matter, since old drivers keep the old contract.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Easee current-setting readback can remain at 15 A while the actual pilot and circuit allocation allow 13 A. Treating the setting as the pilot makes a real charging limit look unexplained. This adds independently confirmed pilot evidence for srcfl/ftw#1874.
Change
pilot_a,pilot_observed_at,pilot_confirmed_at_msanddynamic_limit_aseparately.Dependency
Stacked on #194 at
34347fb92b08474b52e6240b28e78498110ba580, targetingeasee-allocated-limit. This extends that work without rewriting or replacing it. Paired Core extension: srcfl/ftw#1905 (stacked on srcfl/ftw#1537). After driver integration, FTW still needs a separate pin/snapshot update to the merged driver commit; this PR does not publish a signed artifact.Validation
make test-driver ID=easee_cloud: 44 passed, 15 skipped.make check: 4,992 passed, 936 skipped; generated metadata and whitespace checks passed.On 27 October 2026 the paired logic ran locally on FTW v0.157.2-beta.1+local.2 with an Easee cloud charger and Audi e-tron. The live driver was the same logic with unpublished 1.4.1 metadata; this PR's 1.5.0 is a version/catalog change, not a second hardware-tested binary.
load_balancer_limit/info, and the actual EV sheet displayed “Limited by the charger’s load balancing” without a red warning.This is one-site evidence. Charger model/firmware identifiers were not captured, and no claim is made about the exact internal allocation algorithm or which household load triggered it. Communication-loss/recovery and release-of-load-balancing transitions were not hardware-tested here; freshness/order regressions are software evidence. Keep draft pending dependency integration, CI and remaining device identification/review. No site configuration, credentials, raw household history or device identifiers are committed.