Repository navigation
Conversation
BobAnkh
reviewed
Oct 24, 2026
BobAnkh
left a comment
BobAnkh
left a comment
Member
There was a problem hiding this comment.
It is good overall but a little bit confused at some points. Please explain them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tokens now carry a required
roleclaim (1 = user, 2 = worker, 3 = agent), and the four auth middlewares are replaced by one,auth_middleware::<ROLES>. A route lists the roles it accepts (USER,WORKER,AGENT); a token with any other role gets 403 before the handler runs. Handlers for a single role still extractAuthUser/AuthWorker. Handlers open to several roles extractAuthIdentityand match on it. System admin is no longer part of the middleware:/adminlayers a separateadmin_middlewarethat readsAuthUser.admin.Agent hooks, coming in the agent PR, run before any task is fetched, so they have no task uuid to name an attachment by. Workers used to name an attachment by task uuid, and the coordinator looked up that task's group. To give tasks and hooks one attachment endpoint, a worker now names the group directly:
WorkerTaskRespcarriesgroup_name. The coordinator serves the download only while the worker is running a task of that group. Before, any worker token could download any attachment, given any task uuid of its group.