Repository navigation
fix(cli): resolve pnpm catalog references in templates - #565
Open
kunalgoesbyken wants to merge 1 commit into
Open
kunalgoesbyken wants to merge 1 commit into
kunalgoesbyken wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #489
Templates passed with
--templateare uploaded with theirpackage.jsonas-is, socatalog:specifiers reach StackBlitz unresolved and the install fails.--pnpmonly helps for the published packages, becausepnpm packresolves catalogs there, but templates are never packed.This change resolves catalog references in each template before upload, following pnpm's rules:
catalog:andcatalog:defaultresolve fromcatalog, or fromcatalogs.defaultcatalog:<name>resolves fromcatalogs.<name>dependencies,devDependencies,peerDependenciesandoptionalDependenciespnpm-workspace.yamlnearest to the template (found withpkg-types'findNearestFile) and is parsed withconfbox, whichpkg-typesalready usesAs before, the template's
package.jsonis restored once its files are collected, and packages being published still get their pkg.pr.new URLs.Testing
packages/cli/catalog.test.tscovers the default catalog,catalogs.default, named catalogs across all dependency fields, unresolvable specifiers and the no-workspace casevite: "catalog:",react: "catalog:react18",lib: "workspace:*"). Before the fix the uploaded template keptcatalog:; after it, it gets^6.0.0and^18.3.1,libstill points to its pkg.pr.new URL, and the template'spackage.jsonon disk is restored afterwardpnpm run lint:js,pnpm run lint:formatandpnpm install --frozen-lockfilepass