Repository navigation
Fix test containers used on release-0.4 - #2225
Merged
Merged
Conversation
After a change in the Vi/Vim versioned used by Fedora broke our integration tests, we have decided to tag and version all images used in our tests. This patch adds a CI job for building and pushing the images when `tests/containers/QA_TAG` is updated, much like we do in stackrox/collector. It also modifies the existing tests from always building the images to: * Try to find the image locally. * Attempt to pull it if it is not found. * If unable to pulled and allowed to build locally, do that.
* Never rebuild test containers on scheduled builds * Bump test container version * Use debian:trixie as the base distro for 'editors' * Use centos images + pin image versions and packages used This leads to a closer and (hopefully) more stable version of the existing fedora images we were previously using. --------- Co-authored-by: Mauro Ezequiel Moltrasio <mmoltras@redhat.com>
) * chore: validate test images don't exist on remote before building This is a follow up to #2209, we need to backport those changes and we need to ensure release branches will not accidentally overwrite images built in the main branch. A new `exists` make target is added to all test containers and a global check ensures at least one of the images is missing before triggering the rebuild. On normal operation, new versions of the images will be built by the main branch and be available once the QA_TAG bump is backported to release branches. In this case the paths-filter action will determine a rebuild is needed, but the new check will skip building the images. If the images are in the process of being built on the main branch and some of them are not yet pushed, the backported commit will push the images again but they will have been built in such a small span of time the resulting images will pretty much be the same. On PRs, if the containers need to be rebuilt a unique tag is generated and the step will always return the images don't exist. * Global FACT_QA_TAG and portable redirections * Don't conflate network/registry errors with manifest does not exist errors
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the
 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-0.4 #2225 +/- ##
============================================
Coverage 33.38% 33.38%
============================================
Files 22 22
Lines 3630 3630
Branches 3630 3630
============================================
Hits 1212 1212
Misses 2409 2409
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Stringy
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a triple backport for release-0.4:
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Changes validated on their respective original PRs.