Repository navigation
Link XDL's prebuilt emdawnwebgpu instead of the port, so browser apps need no writable Emscripten cache - #3
Merged
Conversation
… need no writable Emscripten cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
XdlSharp.Native.browser-wasmadded--use-port=emdawnwebgputo the link. The port compileswebgpu.cppinto the Emscripten cache at link time, and thewasm-toolsworkload's cache is read-only, so every browser app had to setWasmCachePathto a writable copy of it.Change
XDL_VERSIONis 3.4.20-9, whose browser zip ships emdawnwebgpu prebuilt:emdawnwebgpu.aand its four JavaScript libraries (Ship emdawnwebgpu prebuilt in the browser zip so .NET apps link without a writable Emscripten cache XDL#27).emdawnwebgpu.awithScanForPInvokes="false"and pass the JavaScript libraries with--js-libraryin the port's order, instead of--use-port=emdawnwebgpu.WasmCachePath, so CI links with the workload's read-only cache, as an app does.XdlBrowserDirectorymoves toDirectory.Build.props, becauseXdlSharp.Browser.Testsnow reads it in a property, whichDirectory.Build.targetsis evaluated too late for.Tested locally
--check --clang clang-22).XdlSharp.Tests: 15 passed.XdlSharp.Browser.Testsunder Node: 14 passed.tools/pack.sh, thenXdlSharp.Package.Browser.Testswith the packed packages: all four libraries load, no archive or JavaScript library lands in the published output, andemdawnwebgpuis not in the P/Invoke table.