Repository navigation
Send BMI to Garmin and fix Windows scheduled syncs; 1.15.3 - #82
Merged
Merged
Conversation
…, retry --update once; 1.15.3
…nized wrappers alone, always resolve the program path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release sends BMI to Garmin, fixes Windows scheduled syncs, and makes updates more reliable.
shutil.whichcan return a relative path; Task Scheduler starts the wrapper elsewhere, so every scheduled run failed before eufy-sync started without reporting the failure. Christopher (@smithbuilt) found this in HomeVitals and reported it in A multi-person fork of eufy-sync (HomeVitals), thank you, and an offer #77. Each sync now rewrites the wrapper when its program path is relative or no longer exists, while leaving it alone if the stored program exists or the wrapper cannot be read.--doctoralso compares against the full path.shell.Runout of eufy-sync. HomeVitals starts its program directly, so a missing program raises inside VBScript and opens an error box that blocks later runs. eufy-sync starts throughcmd, which turns the same failure into an exit code.--updateinstallation once after 60 seconds. After two releases, PyPI's version API named the new version before the package index served it. On Windows, the retry runs in the update console, which now receives one command string so a Python path with spaces keeps its quotes; the previous argv list escaped them as\", whichcmddoes not read.pyproject.tomlandeufy_sync/__init__.py.Tests: 793 pass locally on macOS with Python 3.12; ruff is clean. New Windows-only tests run the real wrapper under
cscriptto check exit-code passthrough and a missing program, and run the update console's command line through twocmdlayers with an installer in a "Program Files (x86)" folder that fails once.