Skip to content

shearwater_predator_parser: gate GTR-mode sidemount detection by log version #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeller merged 1 commit into from
Oct 15, 2026
Merged

shearwater_predator_parser: gate GTR-mode sidemount detection by log version #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/shearwater_predator_parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,11 +746,22 @@ shearwater_predator_parser_cache (shearwater_predator_parser_t *parser)
gasmix[i].enabled = (state & (1 << i)) != 0;
}

unsigned int gtrmode = data[offset + 29];
if (popcount(gtrmode) >= 2) {
for (unsigned int i = 0; i < 4; ++i) {
if (gtrmode & (1 << i)) {
tank[i].usage = DC_TANK_USAGE_SIDEMOUNT;
// GTR (Gas Time Remaining) mode, used here only to detect
// sidemount tanks. This byte immediately follows the AI
// mode byte and, like it, requires the wireless air
// integration transmitters, so it is only meaningful once
// AI support appears (logversion >= 7). Before log version
// 13 the only defined values were 0/1/2 (off/T1/T2), which
// never satisfy the sidemount popcount check below; from
// version 13 onward, multiple transmitter bits can be
// combined to flag sidemount configurations.
if (logversion >= 7) {
unsigned int gtrmode = data[offset + 29];
if (popcount(gtrmode) >= 2) {
for (unsigned int i = 0; i < 4; ++i) {
if (gtrmode & (1 << i)) {
tank[i].usage = DC_TANK_USAGE_SIDEMOUNT;
}
}
}
}
Expand Down
Loading