Repository navigation
Polish documentation search and add GA4 tracking - #31
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for suites-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the documentation search modal with consistent light and dark themes, clearer result typography, responsive sizing, and a single pink input focus border. Correct translation keys for the installed DocSearch version and preserve keyboard focus restoration.
Add GA4 events for opening search, viewing results, empty results, and selecting a document. Debounce settled queries and ignore stale responses, cleared queries, and responses received after unmounting.
Validation:
pnpm check: zero errors and warnings.pnpm test: all 13 tests pass.GA4 receipt will need verification after deployment. The homepage metadata is unchanged.