Repository navigation
feat: expose typed Problem details on API errors - #179
Merged
Merged
Conversation
Expose typed Problem details and preserve error response context. Add focused regression coverage and concise integration examples.
Keep the additional properties map immutable while allowing valid JSON null values. Cover typed API errors containing a null extension.
Keep synchronous and asynchronous error classification consistent, and use Problem titles when details are absent. Put error handling beside usage and move contributor instructions out of the README.
Use the supported default property inclusion API while preserving the existing omission of null properties and map entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API errors currently expose their body only as text. This adds typed Problem details, response headers, and the request URI while keeping the original response text.
HTTP failures raise
ApiStatusException; connection failures and timeouts raiseApiConnectionExceptionandApiTimeoutException. All remain catchable asApiException. Response decoding failures remain distinct from connection failures, and Problem details or titles appear in exception messages. Null-valued Problem extensions are preserved. Malformed error bodies remain HTTP failures with their original text, and asynchronous calls use the same exception types.The README shows the common error handling path beside SDK usage, with access to the original response for other error details.
Related to sumup/sumup-py#434 and the Python SDK changes in sumup/sumup-py#436.