Repository navigation
Resolve upgrade set path without SetList::PHP_* constants in PhpUpgradeDowngradeRegisteredInSetRule - #384
Merged
TomasVotruba merged 1 commit intoNov 16, 2026
Conversation
…deDowngradeRegisteredInSetRule
TomasVotruba
deleted the
fix-upgrade-set-rule-without-setlist-constants
branch
November 16, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rector is removing the deprecated
SetList::PHP_*constants. The rule calledconstant(SetList::class . '::PHP_XX'), which crashes PHPStan with an internal error once they are gone.Now the set path is resolved from the
config/setdirectory, usingSetList::CODE_QUALITYlocation. This works with and without the constants. When the set file does not exist, the rule skips.Downgrade sets still use
DowngradeSetListconstants, these are not removed.