Skip to content

Resolve upgrade set path without SetList::PHP_* constants in PhpUpgradeDowngradeRegisteredInSetRule - #384

Merged
TomasVotruba merged 1 commit into
mainfrom
fix-upgrade-set-rule-without-setlist-constants
Nov 16, 2026
Merged

TomasVotruba merged 1 commit into
mainfrom
fix-upgrade-set-rule-without-setlist-constants

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Rector is removing the deprecated SetList::PHP_* constants. The rule called constant(SetList::class . '::PHP_XX'), which crashes PHPStan with an internal error once they are gone.

Now the set path is resolved from the config/set directory, using SetList::CODE_QUALITY location. This works with and without the constants. When the set file does not exist, the rule skips.

Downgrade sets still use DowngradeSetList constants, these are not removed.

@TomasVotruba
TomasVotruba merged commit ea19d26 into main Nov 16, 2026
9 checks passed
@TomasVotruba
TomasVotruba deleted the fix-upgrade-set-rule-without-setlist-constants branch November 16, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant