Repository navigation
fix(chart): keep release versions out of view syncer volume claim labels - #5
Merged
Merged
Conversation
volumeClaimTemplates is immutable, so a chart or appVersion bump made every sync of the StatefulSet fail. An existing StatefulSet has to be recreated once to take this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
volumeClaimTemplatesis immutable, and its labels includedhelm.sh/chartandapp.kubernetes.io/version. Any chart or Zero version bump therefore made syncing the view syncer StatefulSet fail. On Synapdeck nonprod, the 2.4.0 update has been rejected this way, so that StatefulSet is still on the 2.3.1 template.The labels now hold only the stable selector labels and the component.
Upgrading: an existing StatefulSet still has the old labels, so 2.4.1 fails once as well. Delete it with
kubectl delete statefulset <name> --cascade=orphanand let it be recreated. The pods and PVCs stay.Checked: the new test failed before the template change, and
tests/test_templates.pypasses after it.