Skip to content

chore: move to spark review follow-ups #1802

Open

Description

@ovitrif

Refs: #1774

Low-severity item from the review of #1774 that it leaves out:

  • Tests: MoveToSparkRepo.move() (event matching, the in-flight timeout, the fee cap passed to payInvoiceOverLdk) and the state transitions of MoveToSparkViewModel have no unit tests.

Activity

  1. added this to the 3.2.0 milestone on Nov 6, 2026
  2. added theissue type on Nov 6, 2026
  3. ovitrif commented on Nov 6, 2026

    @ovitrif
    CollaboratorAuthor

    Failure matching by payment id and the Connections button's channel source are fixed in #1774 at f715f9d; this issue keeps only the missing unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions