Skip to content

chore: say sdk 37 in the nix flake description - #1792

Merged
jvsena42 merged 1 commit into
masterfrom
chore/flake-description-sdk-37
Nov 5, 2026
Merged

jvsena42 merged 1 commit into
masterfrom
chore/flake-description-sdk-37

Conversation

@jvsena42

@jvsena42 jvsena42 commented Nov 5, 2026

Copy link
Copy Markdown
Member

Follow-up to #1787, from coreyphillips' review: #1787 (review)

Description

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Setup

N/A — no device testing required; the change is flake metadata only.

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

N/A

Evidence

  • One-line change, checked in a nixos/nix container at this branch:
    • nix flake metadata prints "Bitkit Android dev shell (JDK 17 + Android SDK 37/NDK r28b via androidenv)".
    • devShells.x86_64-linux.default.drvPath evaluates to the same derivation as before the edit (n202dzq8…-nix-shell.drv), so the shell itself is unchanged.
  • git diff --check passes.

Gaps

None.

Models used

  • Planning/scoping: claude-opus-5-5 (reasoning: medium)
  • Implementation: claude-opus-5-5 (reasoning: medium)
  • Review: Not performed

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jvsena42 jvsena42 self-assigned this Nov 5, 2026
@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This description-only change is safe to merge.

Summary

Updates the flake.nix description from Android SDK 36 to 37.

  • The Nix flake description now names Android SDK 37.

Reviews (1) · Last reviewed commit: "chore: say sdk 37 in the nix flake descr..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Regtest APK

Built from 25ce099 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

@coreyphillips coreyphillips left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two independent reviews, nothing blocking a merge.

@talosmachina talosmachina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Changes the flake.nix description from Android SDK 36 to 37, to match the platformVersions = [ "37.0" ] that #1787 set. Reviewed 25ce099, light tier (one line, no security path).

What I checked, and 2 candidates I ruled out

Read in full: flake.nix at 25ce099; compileSdk and targetSdk in app/build.gradle.kts
Build: not run. The change is a description string, which nix flake show and nix flake metadata print, and nothing evaluates it into the shell.
CI: green (build-and-test, compose-ui / ui-tests, Greptile)

Ruled out

  • The description now disagrees with targetSdk = 36: the description names the SDK platform the shell installs, and that is 37.0 (compileSdk = 37). targetSdk is not part of the toolchain.
  • buildToolsVersion is still 36.0.0: this PR does not touch it, and the description does not name build-tools.

Merge confidence: 5/5, CI green, and a test would not apply to a description string.

Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed (the run metadata available to this reviewer does not report it)

@jvsena42
jvsena42 merged commit ef7aa67 into master Nov 5, 2026
18 checks passed
@jvsena42
jvsena42 deleted the chore/flake-description-sdk-37 branch November 5, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants