Repository navigation
chore: say sdk 37 in the nix flake description - #1792
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] This description-only change is safe to merge. SummaryUpdates the
Reviews (1) · Last reviewed commit: "chore: say sdk 37 in the nix flake descr..." · Reviewed by Greptile |
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
coreyphillips
left a comment
There was a problem hiding this comment.
Two independent reviews, nothing blocking a merge.
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Changes the flake.nix description from Android SDK 36 to 37, to match the platformVersions = [ "37.0" ] that #1787 set. Reviewed 25ce099, light tier (one line, no security path).
What I checked, and 2 candidates I ruled out
Read in full: flake.nix at 25ce099; compileSdk and targetSdk in app/build.gradle.kts
Build: not run. The change is a description string, which nix flake show and nix flake metadata print, and nothing evaluates it into the shell.
CI: green (build-and-test, compose-ui / ui-tests, Greptile)
Ruled out
- The description now disagrees with
targetSdk = 36: the description names the SDK platform the shell installs, and that is37.0(compileSdk = 37).targetSdkis not part of the toolchain. buildToolsVersionis still36.0.0: this PR does not touch it, and the description does not name build-tools.
Merge confidence: 5/5, CI green, and a test would not apply to a description string.
Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed (the run metadata available to this reviewer does not report it)
Follow-up to #1787, from coreyphillips' review: #1787 (review)
Description
flake.nix: the description now says Android SDK 37. chore: bump the gradle group across 1 directory with 41 updates #1787 moved the dev shell to platform37.0but left the description at 36, whichnix flake showandnix flake metadatadisplay.Design
N/A — no UI changes.
Preview
N/A
QA Notes
Setup
N/A — no device testing required; the change is flake metadata only.
Journeys
N/A — no user-visible behaviour change.
Manual Tests
N/A
Automated Checks
N/A
Evidence
nixos/nixcontainer at this branch:nix flake metadataprints "Bitkit Android dev shell (JDK 17 + Android SDK 37/NDK r28b via androidenv)".devShells.x86_64-linux.default.drvPathevaluates to the same derivation as before the edit (n202dzq8…-nix-shell.drv), so the shell itself is unchanged.git diff --checkpasses.Gaps
None.
Models used
claude-opus-5-5(reasoning:medium)claude-opus-5-5(reasoning:medium)🤖 Generated with Claude Code