Repository navigation
Snapshot: realized paths that start on the cutoff day stay out - #94
Merged
Merged
Conversation
A realized-path partition is named after its prompts' start day, and a 24h path runs into the next day, so the partition dated on the cutoff holds prices from the forward window. build_snapshot now links a partition when the last day its data reaches is in [start, cutoff]: its own day for prices, the next day for a realized-path partition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kmUsyYSEMPGiwbSuvR9hh
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RealizedPathStorenames a partition after the start day of the prompts it holds. A 24h prompt that starts on day D is scored against prices until D + 1, sorealized/<asset>/86400_300/date=D.parquetholds prices from the day after D. Late 1h prompts reach just past midnight too.build_snapshotlinked everydate=*.parquetdated on or before the cutoff. The realized partition dated on the cutoff therefore went into the agents' read-only snapshot, and with it prices from the first day of the forward window the verdict scores.What
build_snapshotlinks a partition when the last day its data reaches is in[start, cutoff]: its own day for a price partition, the next day for a realized-path partition (realized/<asset>/<time_length>_<time_increment>/date=*.parquet). The realized partition dated on the cutoff stays out; the one dated the day before, whose paths end on the cutoff day, stays in.REALIZED_SUBDIRnames the store's directory once; DATA.md's realized summary uses it too.A snapshot already built keeps the links it has: rebuild it to drop a cutoff-day realized partition.
Tests
uv run pytest -q tests/benchmark: 239 passed. black 26.5.1 and flake8 clean.🤖 Generated with Claude Code
https://claude.ai/code/session_016kmUsyYSEMPGiwbSuvR9hh