Skip to content

Snapshot: realized paths that start on the cutoff day stay out - #94

Merged
Thykof merged 1 commit into
mainfrom
fix/snapshot-realized-before-cutoff
Nov 9, 2026
Merged

Thykof merged 1 commit into
mainfrom
fix/snapshot-realized-before-cutoff

Conversation

@Thykof

@Thykof Thykof commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Why

RealizedPathStore names a partition after the start day of the prompts it holds. A 24h prompt that starts on day D is scored against prices until D + 1, so realized/<asset>/86400_300/date=D.parquet holds prices from the day after D. Late 1h prompts reach just past midnight too.

build_snapshot linked every date=*.parquet dated on or before the cutoff. The realized partition dated on the cutoff therefore went into the agents' read-only snapshot, and with it prices from the first day of the forward window the verdict scores.

What

  • build_snapshot links a partition when the last day its data reaches is in [start, cutoff]: its own day for a price partition, the next day for a realized-path partition (realized/<asset>/<time_length>_<time_increment>/date=*.parquet). The realized partition dated on the cutoff stays out; the one dated the day before, whose paths end on the cutoff day, stays in.
  • REALIZED_SUBDIR names the store's directory once; DATA.md's realized summary uses it too.

A snapshot already built keeps the links it has: rebuild it to drop a cutoff-day realized partition.

Tests

  • New: a store with realized partitions dated the day before the cutoff and on it; the snapshot links the first only, while the price partition dated on the cutoff is linked.
  • uv run pytest -q tests/benchmark: 239 passed. black 26.5.1 and flake8 clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_016kmUsyYSEMPGiwbSuvR9hh

A realized-path partition is named after its prompts' start day, and a 24h
path runs into the next day, so the partition dated on the cutoff holds prices
from the forward window. build_snapshot now links a partition when the last
day its data reaches is in [start, cutoff]: its own day for prices, the next
day for a realized-path partition.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016kmUsyYSEMPGiwbSuvR9hh

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@Thykof
Thykof merged commit 39bd62d into main Nov 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant