Repository navigation
feat: harden CLI contract and flow resolution - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue fixed
Closes #44
Summary
runmandatory and keep execution arguments/options on the subcommand.--flowwith--taband--formatwith--output payload|message.--flow-dir; remove directory discovery.--flow-json @pathand update help, README, and unit/integration coverage while preserving runtime and Docker option plumbing.--flow-jsonfalling back to file execution; regression tests cover empty input with and without positional arguments.Validation
make ci— Prettier, ESLint, and 122 tests passed. The make target ignored the audit failure; npm audit reported the same baseline 15 dependency advisories (9 moderate, 6 high).node --test test/integration/cli.integration.test.js test/unit/flow-file.unit.test.js test/unit/cli-params.unit.test.js— 27 passed before the review fix; the updated CLI integration test also passed after it.make install-global; executed 25 acceptance assertions covering help/version, mandatoryrun, default/cwd/flow-dir/explicit paths and no-fallback cases,--tab, inline/stdin/empty/@pathflow JSON, output modes, user-dir modes, and rejection of removed syntax. Successful invocations returned9; message mode returned JSON with payload 9.git diff --checkpassed.Risks / follow-ups