ref(cli): Complete skill command I/O injection - #45
Merged
Merged
Conversation
Base automatically changed from
philprime/ref/inject-command-and-skill-services
to
main
October 2, 2026 08:23
Send remaining skill command output through the shared writer and move skill file reads and atomic writes behind the injected filesystem. Add focused command and filesystem tests for those boundaries.
philprime
force-pushed
the
philprime/ref/complete-skill-io-injection
branch
from
October 2, 2026 08:24
5407329 to
354ce0a
Compare
philprime
marked this pull request as ready for review
October 2, 2026 08:24
philprime
enabled auto-merge (squash)
October 2, 2026 08:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finish the skill-command injection introduced in #44. Skill
get,install, anduninstallnow use the shared output writer, while installation reads and atomic writes go throughAgentSkillFileSystemso tests can control file access without changing CLI output.Review context
Focused tests cover command output and denied filesystem reads and writes.
make test,make analyze,make build, and Docker tests on Linux AMD64 and ARM64 passed. The live network suite remains opt-in.