Skip to content

Add Bun smoke test to CI - #1482

Open
cristianrgreco wants to merge 1 commit into
mainfrom
claude/bun-smoke-test-236cca
Open

cristianrgreco wants to merge 1 commit into
mainfrom
claude/bun-smoke-test-236cca

Conversation

@cristianrgreco

Copy link
Copy Markdown
Collaborator

Summary

Adds a Smoke tests (Bun) CI job that runs the existing CommonJS and ES module smoke tests (start and stop an alpine container) under Bun 1.4.2 (the current latest release; pinned so Bun releases do not break unrelated PRs, to be bumped periodically).

The job mirrors the Node.js smoke test job: build testcontainers with Node.js, prune dev dependencies, then run packages/testcontainers/smoke-test.js and packages/testcontainers/smoke-test.mjs with bun. Like the Node.js smoke tests, it only runs when the testcontainers package changes, and the Checks complete job depends on it.

This replaces the full Bun test matrix proposed in #1433 with a lightweight compatibility signal.

Verification

  • npm run format
  • npm run lint
  • Parsed .github/workflows/checks.yml and confirmed the new job and end dependencies
  • Locally with Bun 1.4.2 against Docker, after npm run build and npm prune --omit=dev --workspace packages/testcontainers:
    • bun packages/testcontainers/smoke-test.js: exit 0
    • bun packages/testcontainers/smoke-test.mjs: exit 0
    • The first run started a fresh Ryuk container, and both processes exited without hanging

Compatibility

Not breaking: CI-only change. No published package code or public API changes.

@cristianrgreco cristianrgreco added maintenance Improvements that do not change functionality patch Backward compatible bug fix labels Oct 6, 2026
@netlify

netlify Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 3129b42
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/6ac540e8c4aaa0000881908c
😎 Deploy Preview https://deploy-preview-1482--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5b2401a6-e9df-4255-b18c-64dc49a016da
📥 Commits

Reviewing files that changed from the base of the PR and between f73de97 and 3129b42.

📒 Files selected for processing (1)
  • .github/workflows/checks.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The checks workflow adds a Bun smoke-test job when the testcontainers module is detected. The job builds and prunes the workspace, installs Bun 1.4.2, and runs CommonJS and ES module smoke tests with DEBUG enabled. The end job now waits for the smoke-test job.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 3129b

The Bun smoke-test job adds CI coverage without an identified merge-blocking risk. Merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a Bun smoke test to CI.
Description check ✅ Passed The description explains the Bun CI job, its smoke tests, when it runs, and the reported verification. It is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improvements that do not change functionality patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant