Repository navigation
Delete the pregenerated RBI before tapioca runs - #33
Merged
Merged
Conversation
e5282df meant to delete rbi/mocktail-pregenerated.rbi before generating, to stop tapioca from merging the previous build's RBI (which the gem exports from rbi/) into the new one. But it put the `rm` after `cd sub_projects/rbi_generator` while keeping the repo-relative path, so it targeted a file that never existed and `rm -f` failed silently. The feedback loop kept going: stale `# source://` comments, including references to sorbet-runtime 0.5.10983, piled up again in rbi/mocktail-pregenerated.rbi and in the sorbet_user sample project's RBI, which merges it in. Move the `rm` above the `cd` so it deletes the real file. A second ./script/build now produces a byte-identical RBI. The committed RBIs still carry the stale comments; they'll come out clean the next time they're regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e5282df meant to delete rbi/mocktail-pregenerated.rbi before generating, to stop tapioca from merging the previous build's RBI (which the gem exports from rbi/) into the new one. But it put the
rmaftercd sub_projects/rbi_generatorwhile keeping the repo-relative path, so it targeted a file that never existed andrm -ffailed silently. The feedback loop kept going: stale# source://comments, including references to sorbet-runtime 0.5.10983, piled up again in rbi/mocktail-pregenerated.rbi and in the sorbet_user sample project's RBI, which merges it in.Move the
rmabove thecdso it deletes the real file. A second ./script/build now produces a byte-identical RBI. The committed RBIs still carry the stale comments; they'll come out clean the next time they're regenerated.