Skip to content

fix(contract): a response without content is not a response without a body - #13

Merged
testomut merged 1 commit into
mainfrom
fix/no-content-is-not-no-body
Nov 9, 2026
Merged

testomut merged 1 commit into
mainfrom
fix/no-content-is-not-no-body

Conversation

@testomut

@testomut testomut commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Only 204 / 205 / 304 and HEAD never carry a body (RFC 9110). A response without documented content is "not described": its body is accepted and not checked, with a note and MISSING_RESPONSE_SCHEMA. Found on Toolshop: 15 correct 422 rejections of POST /products and GET /product-specs/names failed as unexpected-body. Same rule in validator.ts and contract.py; the shared case table (now 25 cases) passes in both.

… body

Only 204 / 205 / 304 and HEAD never carry a body (RFC 9110). A response
without documented content is "not described": its body is accepted and
not checked, with a note (Playwright annotation / pytest warning) and
MISSING_RESPONSE_SCHEMA in coverage-gaps.json. Found on Toolshop: 15
correct 422 rejections of POST /products and GET /product-specs/names
failed as unexpected-body. Same rule in validator.ts and contract.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d69976a1-dd8c-4b68-8aff-172a2fffc449
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@testomut
testomut merged commit 7158fad into main Nov 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant