Repository navigation
Conversation
When dai_num is 1, we can assume that the endpoint is always present and there is no need to check whether the endpoint is present in the SDCA DisCo table. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
🟢 Approval recommended
The narrow condition implements the stated behavior without changing multi-DAI validation.
No open issues 🎉
What changed in this PR
Updates Intel SOF endpoint discovery to assume single-DAI codec endpoints are present.
Changes:
- Skips SDCA DisCo endpoint checks for single-DAI codecs.
- Preserves endpoint validation for multi-DAI codecs.
| File | Description |
|---|---|
| sound/soc/sof/intel/hda.c | Limits endpoint presence checks to multi-DAI codecs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dai_num is 1, we can assume that the endpoint is always present and there is no need to check whether the endpoint is present in the SDCA DisCo table.