Repository navigation
Conversation
| size_t text_offset = 0, rodata_offset = 0; | ||
|
|
||
| shdr_cold.sh_size = 0; | ||
| shdr_coldrodata.sh_size = 0; |
Collaborator
Author
There was a problem hiding this comment.
Thanks @edersondisouza , you are right, the zero inits cannot be removed. I added them back to V2.
Detached sections, like .cold and .coldrodata, are not copied into
their region but stay in the ELF buffer. llext_manager computed their
addresses as the region address plus the section offset returned by
llext_get_section_info(). This only worked by accident, while the
region was used in place. Since Zephyr commit 181077caab27 ("llext:
report no region offset for detached sections"), the offset for a
detached section is (size_t)-1. The .cold partition is no longer added
to the user memory domain and MMU flags are applied to the wrong
pages. Calling a .cold function from a user thread then fails with
EXCCAUSE 18 (instr fetch privilege), e.g. when the DRC module is
loaded.
Use llext_peek() at the section's ELF file offset instead, matching
what Zephyr llext itself does for detached sections. This also
removes the section lookup loop in llext_manager_add_mod_domain().
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202610-llext-cold-fix
branch
from
October 26, 2026 08:59
a3095b5 to
a648cbe
Compare
Collaborator
Author
|
I included the V2 version of this PR and submitted this as non-draft as part of #11355 .. let's merge this together with an Zephyr update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detached sections, like .cold and .coldrodata, are not copied into their region but stay in the ELF buffer. llext_manager computed their addresses as the region address plus the section offset returned by llext_get_section_info(). This only worked by accident, while the region was used in place. Since Zephyr commit 181077caab27 ("llext: report no region offset for detached sections"), the offset for a detached section is (size_t)-1. The .cold partition is no longer added to the user memory domain and MMU flags are applied to the wrong pages. Calling a .cold function from a user thread then fails with EXCCAUSE 18 (instr fetch privilege), e.g. when the DRC module is loaded.
Use llext_peek() at the section's ELF file offset instead, matching what Zephyr llext itself does for detached sections. This also removes the section lookup loop in llext_manager_add_mod_domain().