Repository navigation
Add an agent skill for refactoring onto ts-implscan - #6
Merged
Merged
Conversation
Agents refactoring strategies onto a Dispatchable produced correct code but a different architecture each time. The skill fixes the file layout, naming, context provider, priorities and where provideImplscan() goes, and requires specs of the old selection first. check-layout.mjs ships with the skill and enforces the layout. The package now includes skills/. evals/refactor-skill holds the blind Angular scenarios used to test it, with the results in FINDINGS.md.
Agents using the skill searched the web or npmjs for ts-implscan before installing it. The skill now installs the package first and points at the README in node_modules, which matches the installed version.
The old opening explained the mechanism before the benefit and assumed the reader knows Spring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agents refactoring strategies onto a
Dispatchablewrote correct code, but a different architecture each time. This skill gives every refactor the same shape, and a script checks the layout.The package now ships
skills/.evals/isn't published, and the generator is unchanged.Evidence
Eight blind Angular scenarios, run by fresh agents against hidden tests. Each hazard check was shown to catch a deliberately broken solution, except the import cycle, which is recorded as a generator issue in
FINDINGS.md.check-layout, 22/35 convention checks, 18 new tests keptAfter (final skill): 8/8 hidden test scenarios, 7/7
check-layout, 35/35 convention checks, 52 new tests keptcheck-layoutpasses unchanged on the hand-made demo the layout comes from.npm run test:packagepass locally. The smoke test checks that the tarball contains the skill.Limits:
shared/folder is only covered by unit tests, because it was added after the last blind run.Merge Danger
Door: two-way
Nothing changes at runtime. Reverting removes the skill and the lab. Copies already installed in a project stay until removed.
Blast Radius: packaging
The npm tarball gains about 9 kB. The repo gains about 140 lab fixture files, which CI doesn't run.