Repository navigation
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the documented upgrade-path, cleanup, annotation-support, and release-note linking issues.
9 open issues
What changed in this PR
Adds Typha hold/release guidance for Calico Enterprise and OSS upgrades to prevent simultaneous calico-node disruption.
Changes:
- Adds procedures for operator, Helm, and OpenShift upgrades.
- Adds CE release-note warnings and links.
- Adds OSS upgrade guidance.
| File | Summary | Findings |
|---|---|---|
calico-enterprise_versioned_docs/version-3.24-2/release-notes/index.mdx |
Adds Typha upgrade warning. | Moderate (1 vote): links only to the operator procedure. |
calico-enterprise_versioned_docs/version-3.24-2/getting-started/upgrading/upgrading-enterprise/openshift-upgrade.mdx |
Adds OpenShift hold procedure. | Moderate (3 votes): cleanup is unconditional when no non-cluster hosts exist. Moderate (1 vote): unsupported ignore annotation requires confirmation or replacement. |
calico-enterprise_versioned_docs/version-3.24-2/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/operator.mdx |
Adds operator hold procedure. | Moderate (3 votes): cleanup is unconditional when no non-cluster hosts exist. Moderate (1 vote): unsupported ignore annotation requires confirmation or replacement. |
calico-enterprise_versioned_docs/version-3.24-2/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/helm.mdx |
Adds Helm hold procedure. | Moderate (3 votes): cleanup is unconditional when no non-cluster hosts exist. Moderate (1 vote): unsupported ignore annotation requires confirmation or replacement. |
calico-enterprise_versioned_docs/version-3.24-1/release-notes/index.mdx |
Adds Typha upgrade warning. | Moderate (1 vote): links only to the operator procedure. |
calico-enterprise_versioned_docs/version-3.24-1/getting-started/upgrading/upgrading-enterprise/openshift-upgrade.mdx |
Adds OpenShift hold procedure. | Moderate (3 votes): cleanup is unconditional when no non-cluster hosts exist. Moderate (1 vote): unsupported ignore annotation requires confirmation or replacement. |
calico-enterprise_versioned_docs/version-3.24-1/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/operator.mdx |
Adds operator hold procedure. | Moderate (3 votes): cleanup is unconditional when no non-cluster hosts exist. Moderate (1 vote): unsupported ignore annotation requires confirmation or replacement. |
calico-enterprise_versioned_docs/version-3.24-1/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/helm.mdx |
Adds Helm hold procedure. | Moderate (3 votes): cleanup is unconditional when no non-cluster hosts exist. Moderate (1 vote): unsupported ignore annotation requires confirmation or replacement. |
calico-enterprise_versioned_docs/version-3.23-2/release-notes/index.mdx |
Documents the Typha breaking change. | Moderate (1 vote): links only to the operator procedure. |
calico-enterprise_versioned_docs/version-3.23-2/getting-started/upgrading/upgrading-enterprise/openshift-upgrade.mdx |
Adds OpenShift hold procedure. | Moderate (1 vote): does not cover supported 3.21-to-3.23 upgrades. Moderate (3 votes): cleanup is unconditional when no non-cluster hosts exist. Moderate (1 vote): unsupported ignore annotation requires confirmation or replacement. |
calico-enterprise_versioned_docs/version-3.23-2/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/operator.mdx |
Adds operator hold procedure. | Moderate (1 vote): does not cover supported 3.21-to-3.23 upgrades. Moderate (3 votes): cleanup is unconditional when no non-cluster hosts exist. Moderate (1 vote): unsupported ignore annotation requires confirmation or replacement. |
calico-enterprise_versioned_docs/version-3.23-2/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/helm.mdx |
Adds Helm hold procedure. | Moderate (1 vote): does not cover supported 3.21-to-3.23 upgrades. Moderate (3 votes): cleanup is unconditional when no non-cluster hosts exist. Moderate (1 vote): unsupported ignore annotation requires confirmation or replacement. |
calico_versioned_docs/version-3.33/operations/upgrading/upgrade-notes.mdx |
Adds OSS Typha upgrade guidance. | — |
Review effort: Lite
Comment on lines
+89
to
+92
| ```bash | ||
| kubectl annotate deployment calico-typha -n calico-system unsupported.operator.tigera.io/ignore- | ||
| kubectl annotate deployment calico-typha-noncluster-host -n calico-system unsupported.operator.tigera.io/ignore- | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Done in a3be832. The non-cluster host release command is now its own step, conditional on having held that Typha.
Comment on lines
+98
to
+101
| ```bash | ||
| kubectl annotate deployment calico-typha -n calico-system unsupported.operator.tigera.io/ignore- | ||
| kubectl annotate deployment calico-typha-noncluster-host -n calico-system unsupported.operator.tigera.io/ignore- | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Done in a3be832. The non-cluster host release command is now its own step, conditional on having held that Typha.
Comment on lines
+101
to
+104
| ```bash | ||
| kubectl annotate deployment calico-typha -n calico-system unsupported.operator.tigera.io/ignore- | ||
| kubectl annotate deployment calico-typha-noncluster-host -n calico-system unsupported.operator.tigera.io/ignore- | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Done in a3be832. The non-cluster host release command is now its own step, conditional on having held that Typha.
Comment on lines
+91
to
+94
| ```bash | ||
| kubectl annotate deployment calico-typha -n calico-system unsupported.operator.tigera.io/ignore- | ||
| kubectl annotate deployment calico-typha-noncluster-host -n calico-system unsupported.operator.tigera.io/ignore- | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Done in a3be832. The non-cluster host release command is now its own step, conditional on having held that Typha.
Comment on lines
+98
to
+101
| ```bash | ||
| kubectl annotate deployment calico-typha -n calico-system unsupported.operator.tigera.io/ignore- | ||
| kubectl annotate deployment calico-typha-noncluster-host -n calico-system unsupported.operator.tigera.io/ignore- | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Done in a3be832. The non-cluster host release command is now its own step, conditional on having held that Typha.
Comment on lines
+101
to
+104
| ```bash | ||
| kubectl annotate deployment calico-typha -n calico-system unsupported.operator.tigera.io/ignore- | ||
| kubectl annotate deployment calico-typha-noncluster-host -n calico-system unsupported.operator.tigera.io/ignore- | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Done in a3be832. The non-cluster host release command is now its own step, conditional on having held that Typha.
Comment on lines
+91
to
+94
| ```bash | ||
| kubectl annotate deployment calico-typha -n calico-system unsupported.operator.tigera.io/ignore- | ||
| kubectl annotate deployment calico-typha-noncluster-host -n calico-system unsupported.operator.tigera.io/ignore- | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Done in a3be832. The non-cluster host release command is now its own step, conditional on having held that Typha.
Comment on lines
+98
to
+101
| ```bash | ||
| kubectl annotate deployment calico-typha -n calico-system unsupported.operator.tigera.io/ignore- | ||
| kubectl annotate deployment calico-typha-noncluster-host -n calico-system unsupported.operator.tigera.io/ignore- | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Done in a3be832. The non-cluster host release command is now its own step, conditional on having held that Typha.
Comment on lines
+101
to
+104
| ```bash | ||
| kubectl annotate deployment calico-typha -n calico-system unsupported.operator.tigera.io/ignore- | ||
| kubectl annotate deployment calico-typha-noncluster-host -n calico-system unsupported.operator.tigera.io/ignore- | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
Done in a3be832. The non-cluster host release command is now its own step, conditional on having held that Typha.
ctauchen
marked this pull request as ready for review
October 21, 2026 16:23
Collaborator
Author
|
Replies to the Copilot review summary items that have no inline thread:
Also fixed in a3be832, not raised by the review: the 3.24 pages said "A 3.23 calico-node can connect to a 3.22 Typha". It now reads "A newer calico-node can connect to an older Typha". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typha in CE 3.23 and OSS 3.32 rejects calico-node from earlier releases. This adds the steps to hold Typha during the upgrade, so calico-node rolls out node by node and non-cluster hosts stay connected.
Jira: https://tigera.atlassian.net/browse/DOCS-3127
Changes:
Before merge:
Preview:
The Helm and OpenShift upgrade pages carry the same section. 3.24-1 is not published, so its edits do not appear on the preview.