Repository navigation
Prepare production Let's Talk publication and correct email routing - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The website submits the Forms API key
lets_talk, but the seeded sales-email flow useslets-talk, so those submissions do not route to email. Add a migration that corrects the flow key and reroutes retained submissions missing a receipt, preserving settings, the enabled flag, and successful deliveries.Allow the publication script to select the production API through an explicit allowlisted
FORMS_API_BASE_URL, and document the production release order. Release this before the processor and website rollout. Publishing the production form remains an explicit operation; this PR does not enable email.Validation: lint/build, 69 unit tests, all four migrations on disposable PostgreSQL, and 24 API integration tests passed. The processor's PostgreSQL migration regression also verifies recovery without resending accepted deliveries.
Companion PRs: topcoder-platform/forms-processor-v6#1 and https://github.com/topcoder-platform/topcoder-website/pull/56.