Repository navigation
Conversation
Replaced declarative array mapping and spreading with imperative bounded `for` loops in the backtest runner to reduce intermediate array allocations and garbage collection overhead. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closed in favor of #173. |
💡 What: Replaced declarative array mapping, spreading, and
Setinitialization (Array.from(new Set([...held, ...discovery.candidates.map(...)])).slice(0, maxCandidates)) with imperative, boundedforloops and a trackingSetin the backtest runner.🎯 Why: In hot loops like the backtest session runner, chaining array methods creates unnecessary intermediate arrays and causes GC overhead, even with small array sizes.
📊 Impact: Eliminates several intermediate array allocations per simulation turn, reducing GC pressure and slightly improving overall backtest execution speed.
🔬 Measurement: Verified correctness via
pnpm test. The performance impact can be measured by running backtest benchmarks.PR created automatically by Jules for task 9308923854781300165 started by @toreleon