Repository navigation
fix(vindex): expose policy origins and instrument observability metrics - #190
Merged
mhutchinson merged 1 commit intoNov 12, 2026
Merged
Conversation
- Add Origin() methods on builtPolicy/parsedPolicy and wire.PolicyOrigin helper so single-log C2SP policies auto-populate expected origins. - Add AuditorHalted Prometheus gauge and instrument MPTLockWaitSeconds, MPTMMapBytes, and WitnessWaitSeconds.
patflynn
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up polish to #179 and #183 enabling zero-flag origin inference and wiring remaining Prometheus metrics across upper-stack components:
vindex/internal/wire: AddOrigin() stringon single-logbuiltPolicyandparsedPolicyimplementations pluswire.PolicyOrigin(p any) string(returning""for multi-log policies unless explicitly overridden), keepingwire.Policyas a 1-methodVerify([]byte)interface.vindex/internal/metrics: Addvindex_auditor_haltedgauge (AuditorHalted,SetAuditorHalted,ResetAuditorHalted) and set it on root mismatch.vindex/internal/mpt: Instrumentvindex_mpt_lock_wait_secondsinlockTreeWriteandvindex_mpt_mmap_bytesinupdateDiskBytesMetric.vindex/internal/tree: Instrumentvindex_witness_wait_secondswhen witness cosignatures are configured, and guarduint64 -> int64MPT version conversion inOutputPublisher.PublishKeyBatch.