Repository navigation
fix(vindex): harden deref proof check, mpt close safety, and halted sync guard - #192
Merged
Merged
Conversation
…ync guard - Require non-zero treeSize and treeRoot in FetchVerifiedEntryByIndex and verifyKeysBody, and guard uint64 tile coordinates. - Clear MPT exact flag on Close before unmapping trie files. - Prevent post-halt state mutations in Coordinator and avoid halting on canceled Recover. - Enforce multi-label non-numeric TLDs across DomainToCanonicalKey and ct.wasm, and handle cosignature/v1 witness files in ParseWitnessVerifier.
patflynn
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up hardening across merged VIndex packages (
ingest,mpt,coordinator,auditor,client,wire,wasmhost, andmapfn/examples/ct):vindex/internal/ingest: Make RFC 6962proof.VerifyInclusionmandatory inFetchVerifiedEntryByIndex(rejecting zerotreeSizeor zerotreeRootinstead of skipping proof verification), guarduint64 -> int64tile coordinates, and initializevindex_tile_cache_bytesinNewManagedTileCache.vindex/internal/mpt: Clearm.exactundertreeMuinManager.Closeprior to unmapping backing files so concurrent lock-free readers cannot fault on unmapped memory.vindex/internal/coordinator: ExposeFatalError(), guardRecoverandSyncOnceagainst post-halt mutations, and avoid recording caller context cancellation duringRunrecovery as a permanent fatal halt.vindex/internal/auditor: WireAuditorHaltedPrometheus gauge transitions on startup/halt/progress and expose race-freeVerifier.MetricsAddr().vindex/client&vindex/mapfn/examples/ct: Require non-zeroInputRootwhenInputSize > 0, reject single-label and all-numeric-TLD domains inDomainToCanonicalKey, and enforce the 253-byte DNS wire limit on wildcard domains inct.vindex/internal/wire&vindex/internal/wasmhost: Support file-path inputs forcosignature/v1keys inParseVerifierand guard zero-value&WASMHost{}receivers.