Skip to content

fix(vindex): harden deref proof check, mpt close safety, and halted sync guard - #192

Merged
mhutchinson merged 1 commit into
transparency-dev:mainfrom
mhutchinson:vindex/base-fixes
Nov 17, 2026
Merged

mhutchinson merged 1 commit into
transparency-dev:mainfrom
mhutchinson:vindex/base-fixes

Conversation

@mhutchinson

Copy link
Copy Markdown
Contributor

Summary

Follow-up hardening across merged VIndex packages (ingest, mpt, coordinator, auditor, client, wire, wasmhost, and mapfn/examples/ct):

  • vindex/internal/ingest: Make RFC 6962 proof.VerifyInclusion mandatory in FetchVerifiedEntryByIndex (rejecting zero treeSize or zero treeRoot instead of skipping proof verification), guard uint64 -> int64 tile coordinates, and initialize vindex_tile_cache_bytes in NewManagedTileCache.
  • vindex/internal/mpt: Clear m.exact under treeMu in Manager.Close prior to unmapping backing files so concurrent lock-free readers cannot fault on unmapped memory.
  • vindex/internal/coordinator: Expose FatalError(), guard Recover and SyncOnce against post-halt mutations, and avoid recording caller context cancellation during Run recovery as a permanent fatal halt.
  • vindex/internal/auditor: Wire AuditorHalted Prometheus gauge transitions on startup/halt/progress and expose race-free Verifier.MetricsAddr().
  • vindex/client & vindex/mapfn/examples/ct: Require non-zero InputRoot when InputSize > 0, reject single-label and all-numeric-TLD domains in DomainToCanonicalKey, and enforce the 253-byte DNS wire limit on wildcard domains in ct.
  • vindex/internal/wire & vindex/internal/wasmhost: Support file-path inputs for cosignature/v1 keys in ParseVerifier and guard zero-value &WASMHost{} receivers.

…ync guard

- Require non-zero treeSize and treeRoot in FetchVerifiedEntryByIndex and verifyKeysBody, and guard uint64 tile coordinates.
- Clear MPT exact flag on Close before unmapping trie files.
- Prevent post-halt state mutations in Coordinator and avoid halting on canceled Recover.
- Enforce multi-label non-numeric TLDs across DomainToCanonicalKey and ct.wasm, and handle cosignature/v1 witness files in ParseWitnessVerifier.
@mhutchinson
mhutchinson requested a review from patflynn November 17, 2026 10:25
@mhutchinson
mhutchinson merged commit e69d63a into transparency-dev:main Nov 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants