Repository navigation
Use C ABI types for GLFW callbacks - #196
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native backend cannot register its resize and scroll callbacks when their Nim primitive parameter types differ from the C types declared by StaticGLFW. Use
cintfor framebuffer dimensions andcdoublefor scroll offsets to match the callback signatures.Validation:
nim check, native library and minimal example builds, and minimal JavaScript example build.GUI examples were compiled without launching them.
CI: the Ubuntu rerun passes all 28 native and 28 JavaScript example builds after the StaticGLFW dependency fix in treeform/staticglfw#20 was merged. No additional Fidget source changes were needed.