Skip to content

linux runtime: build on hosts without SOCK_CLOEXEC #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turinglambdaai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

linux runtime: build on hosts without SOCK_CLOEXEC #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion platform/linux/runtime/backend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,20 @@ struct SocketEndpoints {

SocketEndpoints create_socket_endpoints() {
int fds[2]{-1, -1};
if (::socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, fds) != 0) {
#if defined(SOCK_CLOEXEC)
int const rc = ::socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, fds);
#else
// Platforms without SOCK_CLOEXEC (macOS): set the flag on both ends right
// after the pair exists; this thread does no I/O in between.
int rc = ::socketpair(AF_UNIX, SOCK_STREAM, 0, fds);
if (rc == 0) {
if (::fcntl(fds[0], F_SETFD, FD_CLOEXEC) != 0 ||
::fcntl(fds[1], F_SETFD, FD_CLOEXEC) != 0) {
rc = -1;
}
}
#endif
if (rc != 0) {
throw std::runtime_error("socketpair failed: " +
std::string(std::strerror(errno)));
}
Expand Down
Loading