Repository navigation
Document per-owner capabilities and lint conditional none branches - #236
Merged
SandroMaglione merged 5 commits intoOct 22, 2026
Merged
Conversation
Add React guide sections on `none` versus declinable acceptance, per-owner capability services, and emissions, plus review and agent guide notes. Add the recommended `effect-machine/no-conditional-none-branch` Oxlint rule. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MHnF2EL6ReDTKwoM9TVH7L
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MHnF2EL6ReDTKwoM9TVH7L
…ies-and-none-branch-lint # Conflicts: # packages/effect-machine/docs/effect-atom-react.md
…ies-and-none-branch-lint
…ies-and-none-branch-lint
SandroMaglione
deleted the
react-guide-capabilities-and-none-branch-lint
branch
October 22, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/effect-machine/docs/effect-atom-react.md):{ none: true }branch selected by a resolver still counts as accepted forcan. Shows the before/after resolver (guard, ordeclinable: truewithdecline()), and says render-time acceptance should useAtomMachine.can(event)(machine), notEffect.runSync(Machine.can(...)).Context.Servicethat a state invokes. The React owner provides it withAtomMachine.bind(Atom.runtime(Layer.merge(AppLayer, ownerLayer)))inside theuseMachineAtomfactory. The section covers snapshot encoding,Layer.mock, sharing the app layer through the registry memo map, and the compile error when the machine is bound without the service.Atom.make(stream)re-publishes the last emission when the machine completes, anduseAtomSubscribeneeds{ immediate: true }.machine-review.mdandagent-guide.md: review checks and guidance fornoneversusdeclinable, capability services instead of function-valued schema fields, and keeping navigation out of emissions.effect-machine/no-conditional-none-branch. It reports a resolver that conditionally selects a branch declared{ none: true }in the same module'sMachine.make({ branches })when the transition lacksdeclinable: true. It recognisesselect.<key>(), destructured selectors, context-parameter selectors, nested ternaries, logical expressions andif/switchreturns. README, recommended config and pack check are updated. The plugin README's nondeterminism example now usesdeclinableso it passes the new recommended rule.Changeset
@typeonce/oxlint-plugin-effect-machine; documentation-only files need no changeset)Validation
pnpm check: every step passed locally exceptformat:check, which could not download dprint plugins in the sandbox, so CI runs it. One devtoolsStaticSitetest hit a 5s timeout under load and passed when rerun alone. The guide snippets (per-owner runtime, missing-service compile error, before/after resolvers) were typechecked in a scratch tstyche file that is not committed.Generated by Claude Code