fix(stovepipe): separate record dlq handler - #726
Merged
Merged
Conversation
Summary: Intent: - Prevent permanent promotion failures from occupying the record DLQ indefinitely. - Preserve successful validation state while making abandoned promotion visible in request history. Changes: - Add record-specific DLQ handling that does not repeat known promotion failures. - Retain an idempotent promotion_failed history event before acknowledging abandoned promotion work. - Keep non-promotion reconciliation under the existing DLQ retry policy. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
marked this pull request as ready for review
September 21, 2026 14:43
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 21, 2026 14:43
mnoah1
enabled auto-merge
September 21, 2026 14:43
behinddwalls
approved these changes
Sep 22, 2026
behinddwalls
deleted the
mnoah1/stovepipe-promotion-dlq-reconciliation
branch
September 22, 2026 19:22
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During the record step, we were previously reusing the existing record handler as the dlq handler. Since record has outbound side effects (e.g. Promote), this can lead to 1000x attempts to external APIs even if the request will never succeed.
This PR adds a separate DLQ handler for record, focused on repair/recording an event for the abandoned record attempt, rather than repeated attempts that will likely continue to fail if the original retry budget is exhausted.
Intent:
Changes:
record_abandonedhistory event.