Repository navigation
Conversation
Start a new onboarding experiment that compares the welcome-overlay flow (variant C, now the control) with a simplified variant D. Variant letters now name a UI pattern rather than a role, so the control is chosen per experiment and C keeps meaning the same pattern it did in onboarding_v3. The kill switch and the failed-assignment fallback both land on C. Variant A is no longer assigned but stays in the type until its code is removed. Add onboarding_v4 to the hub experiments config, keeping onboarding_v3 for already-published builds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H7m4SrJWH9ySfRuqRtDVg6
…ground Variant D drops the "select -> command -> result" OnboardingRail from Steps 1-3 and replaces the slate vignette with the welcome overlay's blue radial glow, kept behind every step. The glow is extracted into OnboardingGlow and mounted by both the overlay and the layout at the same time, so the overlay fades out onto an identical, already-bloomed glow. Variant differences are resolved once in getVariantUi() and exposed as onboarding.ui, so steps check `ui.showRail` instead of variant letters. Steps 1 and 2 keep extra room above the target text without the rail so its callout does not overlap the explanation. Add variant D shots to the onboarding screenshot spec and pin the other shots to an explicit variant. Refs #494 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H7m4SrJWH9ySfRuqRtDVg6
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 55.15% 55.33% +0.17%
==========================================
Files 294 295 +1
Lines 29904 29932 +28
Branches 3044 3052 +8
==========================================
+ Hits 16494 16563 +69
+ Misses 13410 13369 -41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #494
概要
Onboarding の D案(C案+シンプル化)を実装し、新しい実験
onboarding_v4で C案(対照群)と D案 を比較します。変更内容
実験構成(
onboarding_v4)onboarding_v4に変更し、振り分けをrandom < allocation ? "D" : "C"に変更types.tsのコメントを更新)。C の値の意味は v3 と変わらず、GA4 上はexperiment_idで区別できますExperimentVariantに"D"を追加。"A"はもう割り当てられませんが、コード削除は別対応とするため型と?variant=Aは残していますexperiments.jsonにonboarding_v4を追加(公開済みビルドのためonboarding_v3は残しています)。DEFAULT_CONFIGSも更新D案の UI
getVariantUi()(onboardingVariantUi.ts)にまとめ、onboarding.uiとして渡すようにしました。各ステップには variant の文字を判定する分岐を書いていませんui.showRail = falseのとき、Step 1〜3 のOnboardingRailを表示しないpb-14で余白を確保OnboardingGlowとして切り出し、D案ではこれをOnboardingLayoutの背景に使用(ui.background = "glow")テスト
onboarding_v4に合わせて更新OnboardingLayoutの背景切り替えテストを追加確認
yarn test(extension):108 files / 1503 tests passedyarn lint:エラーなしyarn build:e2eのビルドで C/D の各画面(Welcome、Step 1〜4 の explain / value_shown)を ja ロケールでキャプチャし、目視確認🤖 Generated with Claude Code
https://claude.ai/code/session_01H7m4SrJWH9ySfRuqRtDVg6