Skip to content

Create plasma rad class - #4695

Open
chris-ashe wants to merge 6 commits into
mainfrom
create_plasma_rad_class
Open

chris-ashe wants to merge 6 commits into
mainfrom
create_plasma_rad_class

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Description

  • Move all radiation calcs into a new class called PlasmaRadiation.
  • Physics class now has composition with PlasmaRadiation
  • Dedicated output method now for radiation and is pulled from outplas()

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added Radiation Plasma radiated power Refactor labels Oct 16, 2026
@codecov-commenter

codecov-commenter commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.49533% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.34%. Comparing base (39e7dcd) to head (5426feb).

Files with missing lines Patch % Lines
process/models/physics/radiation_power.py 18.36% 80 Missing ⚠️
process/models/physics/physics.py 33.33% 2 Missing ⚠️
process/models/physics/impurity_radiation.py 66.66% 1 Missing ⚠️
process/models/stellarator/stellarator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4695      +/-   ##
==========================================
+ Coverage   50.26%   50.34%   +0.07%     
==========================================
  Files         181      181              
  Lines       30627    30655      +28     
==========================================
+ Hits        15395    15433      +38     
+ Misses      15232    15222      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe
chris-ashe marked this pull request as ready for review October 16, 2026 11:08
@chris-ashe
chris-ashe requested a review from a team as a code owner October 16, 2026 11:08
@chris-ashe
chris-ashe force-pushed the create_plasma_rad_class branch from 816bd7b to 27f73da Compare October 16, 2026 14:25
@timothy-nunn timothy-nunn self-assigned this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Radiation Plasma radiated power Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants