Repository navigation
Scale constraint 93 to have residual in Z.particles/s - #4702
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4702 +/- ##
=======================================
Coverage 50.26% 50.26%
=======================================
Files 181 181
Lines 30627 30627
=======================================
Hits 15395 15395
Misses 15232 15232 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timothy-nunn
marked this pull request as ready for review
October 19, 2026 15:05
grmtrkngtn
approved these changes
Oct 20, 2026
grmtrkngtn
left a comment
grmtrkngtn
left a comment
Collaborator
There was a problem hiding this comment.
I don't see an issue with this in principle - scaling seems sensible.
clmould
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think some of the failures we are seeing on main relate to several different solutions being found where constraint 93 (the new fuel ion equilibrium constraint) is satisfied slightly differently but well within tolerance. I think this can happen because the values the solver is seeing are so large ($10^{21}$ ). Converting the constraint to be in zeta-particles per second should stop this from happening.