Repository navigation
Fix/adaptive ring storage - #104
Open
shravankumargulvadi wants to merge 2 commits into
Open
shravankumargulvadi wants to merge 2 commits into
shravankumargulvadi wants to merge 2 commits into
Conversation
Allocate elevation/flatness thresholds and histories for num_rings_of_interest instead of assuming four rings. Reject counts outside the configured CZM ring range before allocating storage.
Extend the existing Python smoke test to cover zero, default, expanded and total checked rings across repeated scans. Check rejection of negative and excessive counts.
Author
|
@LimHyungTae @seungjae24 can either of you please take a look, thanks |
Author
|
@LimHyungTae @seungjae24 sending a reminder to make sure this is on your radar, thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes out-of-bounds access when more than four rings use adaptive thresholds. Thresholds and histories now match the configured ring count.
Extends the existing test to cover different ring counts and repeated scans. The six-ring case fails without the fix, all 9 tests pass with it.