Skip to content

Fix/adaptive ring storage - #104

Open
shravankumargulvadi wants to merge 2 commits into
url-kaist:masterfrom
shravankumargulvadi:fix/adaptive-ring-storage
Open

shravankumargulvadi wants to merge 2 commits into
url-kaist:masterfrom
shravankumargulvadi:fix/adaptive-ring-storage

Conversation

@shravankumargulvadi

Copy link
Copy Markdown

Fixes out-of-bounds access when more than four rings use adaptive thresholds. Thresholds and histories now match the configured ring count.

Extends the existing test to cover different ring counts and repeated scans. The six-ring case fails without the fix, all 9 tests pass with it.

Allocate elevation/flatness thresholds and histories for num_rings_of_interest instead of assuming four rings. Reject counts outside the configured CZM ring range before allocating storage.
Extend the existing Python smoke test to cover zero, default, expanded and total checked rings across repeated scans. Check rejection of negative and excessive counts.
@shravankumargulvadi

Copy link
Copy Markdown
Author

@LimHyungTae @seungjae24 can either of you please take a look, thanks

@shravankumargulvadi

Copy link
Copy Markdown
Author

@LimHyungTae @seungjae24 sending a reminder to make sure this is on your radar, thanks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant