Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe build script now stops before packaging when the binary fails its startup check, while preserving its exit code and error output.
No actionable issues found. Reviews (1) · Last reviewed commit: "fix(build): stop packaging when the bina..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the standalone binary exits nonzero on
--help,scripts/build.shcurrently creates the release archive and exits successfully. A caller can then pick up an archive for a binary that never started.Check the built binary before creating the release directory or archive. Preserve the executable's exit status and stderr on failure. Successful builds keep their current archive layout.
Refs #1533. This addresses the smoke-test failure path in the documented local build command. The broader build refactor in #1532 can proceed independently.
Validation
8db295a5, both failure cases reproduced the false success with a stub executable that exits 7.git diff --checkpassed. ShellCheck reported the same preexisting SC2012 note.