Skip to content

fix(build): stop packaging when the binary smoke test fails - #1784

Open
samirhvbr wants to merge 1 commit into
usestrix:mainfrom
samirhvbr:fix/build-smoke-failure-20261119
Open

samirhvbr wants to merge 1 commit into
usestrix:mainfrom
samirhvbr:fix/build-smoke-failure-20261119

Conversation

@samirhvbr

Copy link
Copy Markdown
Contributor

When the standalone binary exits nonzero on --help, scripts/build.sh currently creates the release archive and exits successfully. A caller can then pick up an archive for a binary that never started.

Check the built binary before creating the release directory or archive. Preserve the executable's exit status and stderr on failure. Successful builds keep their current archive layout.

Refs #1533. This addresses the smoke-test failure path in the documented local build command. The broader build refactor in #1532 can proceed independently.

Validation

  • On upstream 8db295a5, both failure cases reproduced the false success with a stub executable that exits 7.
  • After the change, the build and installer tests passed (6 tests). The regressions exercise success and failure for tar and simulated Windows ZIP packaging.
  • Ruff lint and formatting, Bash syntax and git diff --check passed. ShellCheck reported the same preexisting SC2012 note.
  • Mypy, Bandit and the lockfile check passed. Pyright reported the same 953 errors as the base.
  • Tests used stub build tools. A full PyInstaller build and native Windows packaging were outside this validation.

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

The build script now stops before packaging when the binary fails its startup check, while preserving its exit code and error output.

  • Release builds check the binary before making packages.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(build): stop packaging when the bina..." · Reviewed by Greptile

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant