Skip to content

Add network test users with Active Directory accounts to cloud CLI - #1791

Open
bearsyankees wants to merge 2 commits into
mainfrom
feat/str-2767-cli-directory-test-users
Open

bearsyankees wants to merge 2 commits into
mainfrom
feat/str-2767-cli-directory-test-users

Conversation

@bearsyankees

@bearsyankees bearsyankees commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds a strix cloud networks group for the /networks/{networkId}/test-users API, which supports Active Directory accounts. The new fields (auth_kind, directory_domain) exist only on network test users. The domains test-users bodies are unchanged.

strix cloud networks test-users list|add|update|remove|verify|verify-status NETWORK_ID [USER_ID]

strix cloud networks test-users add <connector-id> --label Auditor --username auditor \
  --auth-kind directory --directory-domain CORP.EXAMPLE --data @credentials.json
  • NETWORK_ID is a connector ID from strix cloud connectors list, or direct on a self-hosted install.
  • The help matches the API contract. auth_kind is web (default) or directory. Directory accounts need directory_domain and a password and do not accept login_url. Web accounts need login_url. mfa_method is none or totp.
  • Only label and username are required flags on add. The server validates the conditional rules, so a directory add does not need --login-url.
  • Tests cover help, request bodies for directory and web add, update, action paths, and completions. The docs (docs/cloud/cli.mdx, README, AGENTS.md, and the managed-pentesting skill) describe the new commands.

Closes STR-2767


Technical Writer opened this PR for Alex
Implemented in session Update strix CLI scan_tier help after tier removal
Review with Devin · Open in Devin Desktop


@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Adds cloud CLI commands to manage web and Active Directory test accounts on networks.

  • The cloud CLI manages network test users with web or directory accounts.

No actionable issues found.

Reviews (1) · Last reviewed commit: "Clarify network ID help" · Reviewed by Greptile

@arcanist

arcanist Bot commented Nov 19, 2026

Copy link
Copy Markdown

Ready to merge Re-run Arcanist review

PR summary

The cloud CLI previously had no commands for network test users. It now supports listing, adding, updating, removing, and verifying web and Active Directory accounts through strix cloud networks test-users.

🟡 Medium blast radius. If this breaks (1):
  1. People using the managed CLI get malformed credentials for network test users or can't add and verify those accounts.
Flow diagram
%%{init: {"theme": "neutral"}}%%
flowchart TD
  n0["Cloud CLI dispatch"]
  n1["Add network account creation"]
  n0 --> n1
  n2["Include directory sign-in fields"]
  n1 --> n2
  n3["Run the cloud command"]
  n2 --> n3
  n4["Prepare the account request"]
  n3 --> n4
  n5["Send account details"]
  n4 --> n5
  n6["Account response arrives"]
  n5 --> n6
  n7["Return the API result"]
  n6 --> n7
  n8["Check the API response"]
  n7 --> n8
  n9["Pass back the result"]
  n8 --> n9
  n10["Show the account result"]
  n9 --> n10
Loading
✅ Ruled out (2)
  • Does the network account list hide the IDs needed for later commands?
    No, the list showed the account ID and label and reported one item, so later commands can still select that account.
  • Can verification wait until its timeout after the result has failed?
    No, polling stopped at the failed result, printed its failure code, and returned successfully instead of waiting for the timeout.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant