Repository navigation
Add network test users with Active Directory accounts to cloud CLI - #1791
Open
bearsyankees wants to merge 2 commits into
Open
bearsyankees wants to merge 2 commits into
bearsyankees wants to merge 2 commits into
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
[Medium impact] The PR appears safe to merge. SummaryAdds cloud CLI commands to manage web and Active Directory test accounts on networks.
No actionable issues found. Reviews (1) · Last reviewed commit: "Clarify network ID help" · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
strix cloud networksgroup for the/networks/{networkId}/test-usersAPI, which supports Active Directory accounts. The new fields (auth_kind,directory_domain) exist only on network test users. Thedomains test-usersbodies are unchanged.NETWORK_IDis a connector ID fromstrix cloud connectors list, ordirecton a self-hosted install.auth_kindisweb(default) ordirectory. Directory accounts needdirectory_domainand a password and do not acceptlogin_url. Web accounts needlogin_url.mfa_methodisnoneortotp.labelandusernameare required flags onadd. The server validates the conditional rules, so a directory add does not need--login-url.docs/cloud/cli.mdx, README, AGENTS.md, and the managed-pentesting skill) describe the new commands.Closes STR-2767
Implemented in session Update strix CLI scan_tier help after tier removal
Review with Devin · Open in Devin Desktop