Repository navigation
fix(prompt): a skill named like a template argument no longer empties the prompt - #1792
Closed
ian-at-strix wants to merge 1 commit into
Closed
ian-at-strix wants to merge 1 commit into
ian-at-strix wants to merge 1 commit into
Conversation
… the prompt The template reads skill bodies through get_skill, so passing them as keyword arguments too only let a skill named methodology, interactive or is_root collide with the template's own arguments and empty the whole prompt.
Contributor
[Medium impact] This PR appears safe to merge. SummaryFixes empty system prompts when a loaded skill shares a name with a template argument.
No actionable issues found. Reviews (2) · Last reviewed commit: "fix(prompt): a skill named like a templa..." · Reviewed by Greptile |
Contributor
Author
|
Superseded by #1782, which removes --methodology. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render_system_promptpassed every loaded skill body to the template as a keyword argument named after the skill, next to its own arguments. A skill namedmethodology(new in #1779),interactive,is_root, … raised a duplicate-keyword error, which the renderer catches, so the agent ran with an empty system prompt. Example:strix --skills-dir ./skills --skills custom/methodology.The template reads skills only through
get_skill, so this drops the keyword spread. Regression test included; it fails on main.