Repository navigation
Add org skills commands to cloud CLI - #1793
bearsyankees wants to merge 1 commit into
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
[Medium impact] The PR adds organization-skill management to the cloud CLI. The PR appears safe to merge, with a non-blocking terminal display issue. Findings
Fix with agent prompt### Issue 1
strix/interface/cloud/spec.py:792-797
**Skill output hides records.** The new commands do not register their response shapes with the terminal renderer. A `{"skills":[...],"total":n}` response becomes a nested preview that shows only five names and cuts each at 60 characters. A `{"skill":{...}}` response also becomes a preview, cutting Markdown content at 60 characters instead of using the longer detail view.
Add list and detail mappings for these responses and cover terminal output in the tests. The current read tests always use `--json`, which skips this path.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryAdds organization skill commands to the cloud CLI, with request fields, help text, completion coverage, and usage docs.
Reviews (1) · Last reviewed commit: "Add org skills commands to cloud CLI" · Reviewed by Greptile |
| "skills list": Cmd( | ||
| "GET", | ||
| "/knowledge/skills", | ||
| "List custom skills. Requires knowledge:read. " | ||
| "Asset-scoped tokens cannot access skills.", | ||
| ), |
There was a problem hiding this comment.
Skill output hides records. The new commands do not register their response shapes with the terminal renderer. A
{"skills":[...],"total":n} response becomes a nested preview that shows only five names and cuts each at 60 characters. A {"skill":{...}} response also becomes a preview, cutting Markdown content at 60 characters instead of using the longer detail view.
Add list and detail mappings for these responses and cover terminal output in the tests. The current read tests always use --json, which skips this path.
Knowledge Base Used: Cloud commands and sessions
Prompt To Fix With AI
This is a comment left during a code review.
Path: strix/interface/cloud/spec.py
Line: 792-797
Comment:
**Skill output hides records.** The new commands do not register their response shapes with the terminal renderer. A `{"skills":[...],"total":n}` response becomes a nested preview that shows only five names and cuts each at 60 characters. A `{"skill":{...}}` response also becomes a preview, cutting Markdown content at 60 characters instead of using the longer detail view.
Add list and detail mappings for these responses and cover terminal output in the tests. The current read tests always use `--json`, which skips this path.
**Knowledge Base Used:** [Cloud commands and sessions](https://app.greptile.com/-/switch-tenant?tenant=strix-org-3&next=%2Fcustom-context%2Fknowledge-base%2Fusestrix%2Fstrix%2F-%2Fdocs%2Fcloud-commands-and-sessions.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.There was a problem hiding this comment.
Doesn't block merge. In an interactive terminal, knowledge skills list falls back to a preview of five skill names, and knowledge skills get previews the skill object, shortening or omitting its Markdown content. The renderer tells users to use --json, and that mode prints the complete response from the same read commands, so they can retrieve every record and the full content. The command runner passes both responses to the renderer, whose view mappings contain neither skill response.
There was a problem hiding this comment.
Agreed—this is non-blocking. --json provides a way to retrieve the complete list and Markdown content; the interactive renderer’s truncated preview remains a usability issue, not a merge blocker.
Summary
Adds
strix cloud knowledge skillscommands for the organization skills API (/knowledge/skillsand/knowledge/skills/{skillName}). Agents load these skills asorg/<name>.createrequiresname,description, andcontent.updatecannot change the name.scopeis a JSON array of{"type":"repo","id":...}entries. An omitted scope or[]means organization-wide.knowledge:read. Writes needknowledge:writeand an organization admin for personal tokens.--data @fileJSON body. The server still validates the limits.docs/cloud/cli.mdx, AGENTS.md, and the managed-pentesting skill describe the commands.Closes STR-2776
Implemented in session Update strix CLI scan_tier help after tier removal
Review with Devin · Open in Devin Desktop