Skip to content

Added a new overload to URI Resolver Registry that emulated the old behavior of resolving if possible - #2929

Merged
DavyLandman merged 1 commit into
mainfrom
fix/fall-out-from-stricter-resolve
Oct 13, 2026
Merged

DavyLandman merged 1 commit into
mainfrom
fix/fall-out-from-stricter-resolve

Conversation

@DavyLandman

Copy link
Copy Markdown
Member

The recent changes to the resolver #2901 was not compatible with how in other parts of the rascal code-base we would often resolve away locations just to be sure.

This causes some subtle bugs in for example PathConfig.java.

This PR introduces a new function on URIResolverRegistry that has a better name, and emulates the old behavior (with the benefit of never returning null).

@DavyLandman
DavyLandman requested a review from sungshik October 13, 2026 08:52
@DavyLandman
DavyLandman force-pushed the fix/fall-out-from-stricter-resolve branch from 3a5036a to c6d6328 Compare October 13, 2026 08:56
@DavyLandman
DavyLandman force-pushed the fix/fall-out-from-stricter-resolve branch from c6d6328 to 58e6931 Compare October 13, 2026 09:00
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 22.00000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 45%. Comparing base (8fe8d6d) to head (58e6931).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/ShellExec.java 0% 25 Missing ⚠️
src/org/rascalmpl/library/util/TermREPL.java 0% 4 Missing ⚠️
src/org/rascalmpl/library/util/PathConfig.java 66% 3 Missing ⚠️
...rc/org/rascalmpl/ideservices/BasicIDEServices.java 0% 2 Missing ⚠️
...rascalmpl/uri/file/MavenRepositoryURIResolver.java 0% 1 Missing and 1 partial ⚠️
src/org/rascalmpl/library/util/Benchmark.java 0% 1 Missing ⚠️
...rascalmpl/uri/remote/RascalFileSystemServices.java 0% 1 Missing ⚠️
src/org/rascalmpl/uri/zip/ZipURIResolver.java 0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2929   +/-   ##
=======================================
- Coverage       45%     45%   -1%     
+ Complexity    6814    6810    -4     
=======================================
  Files          844     844           
  Lines        68842   68817   -25     
  Branches     10040   10038    -2     
=======================================
- Hits         31433   31412   -21     
+ Misses       35013   35004    -9     
- Partials      2396    2401    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavyLandman
DavyLandman merged commit 9b3ee66 into main Oct 13, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant