Repository navigation
Added a new overload to URI Resolver Registry that emulated the old behavior of resolving if possible - #2929
Merged
Conversation
DavyLandman
force-pushed
the
fix/fall-out-from-stricter-resolve
branch
from
October 13, 2026 08:56
3a5036a to
c6d6328
Compare
…ehavior of resolving if possible
DavyLandman
force-pushed
the
fix/fall-out-from-stricter-resolve
branch
from
October 13, 2026 09:00
c6d6328 to
58e6931
Compare
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
=======================================
- Coverage 45% 45% -1%
+ Complexity 6814 6810 -4
=======================================
Files 844 844
Lines 68842 68817 -25
Branches 10040 10038 -2
=======================================
- Hits 31433 31412 -21
+ Misses 35013 35004 -9
- Partials 2396 2401 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The recent changes to the resolver #2901 was not compatible with how in other parts of the rascal code-base we would often resolve away locations just to be sure.
This causes some subtle bugs in for example
PathConfig.java.This PR introduces a new function on
URIResolverRegistrythat has a better name, and emulates the old behavior (with the benefit of never returningnull).