Repository navigation
feat(brand): socket doorway, plugin icon and a GitHub social preview - #13
Merged
Merged
Conversation
- server/castlegate_server/icon.png is assets/castlegate-mark.svg drawn at 128 pixels square, and metadata.txt names it, so QGIS shows it beside the plugin. - assets/social-preview.png is a 1280 by 640 card for the repository's social preview: the mark, the name and the repository's description, on Vectoria's dark navy with its logo. - Verified: python scripts/build.py puts icon.png in the plugin zip; python -m unittest discover -s tests/core -t . and -s tests/plugin -t . pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125SG3UAHYDLELQvrNCq7Cv
- assets/social-preview.png's tagline reads "Per-user access control for QGIS Server, with OpenID Connect sign-in", the README's word for the people Castlegate serves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125SG3UAHYDLELQvrNCq7Cv
- On assets/social-preview.png the mark's arrow slits, doorway and floor are transparent, so they take the card's navy. assets/castlegate-mark.svg is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125SG3UAHYDLELQvrNCq7Cv
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
- assets/castlegate-mark.svg: the four arrow slits are now holes through the orange walls, as the doorway is through the green. They were black drawn over unbroken orange, so taking the black away left orange, not the page. The black inside the slits and the doorway carries class="interior", and a comment at the top of the file says how the openings are built. - The mark looks the same. assets/social-preview.png is redrawn from it with the interior shapes removed, so the card's navy shows through the slits as well as the doorway, and server/castlegate_server/icon.png is redrawn from the new file. - Verified: rendered on white, GitHub's dark and a bright test colour in Chromium; with the interior shapes removed, the test colour shows through all four slits and the doorway. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125SG3UAHYDLELQvrNCq7Cv
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
- assets/castlegate-mark.svg: the doorway keeps its width and is lower, 36 units to the top of its tab against 43. It steps in twice, each step a merlon's height, to a tab three blocks wide. The yellow surround is a rectangle whose top is level with the tab, so the tab meets the green wall, and it carries a green light and an orange light over the outer steps. The doorway's inward-facing yellow is darker, to set it apart from the yellow that faces out. - server/castlegate_server/icon.png and assets/social-preview.png are redrawn from the new mark; the card still removes the class="interior" shapes so its navy shows through the openings. - Verified: rendered on white, GitHub's dark and a bright test colour in Chromium; with the interior shapes removed, the test colour shows through all four slits and the doorway. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125SG3UAHYDLELQvrNCq7Cv
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
assets/castlegate-mark.svg:class="interior", and a comment at the top of the file says how the openings are built.server/castlegate_server/icon.pngis the mark drawn at 128 pixels square, with a transparent background.metadata.txtnames it withicon=icon.png, so QGIS shows it beside the plugin.assets/social-preview.pngis a 1280 × 640 card for the repository's social preview: the mark, "Castlegate" in Outfit, and "Per-user access control for QGIS Server, with OpenID Connect sign-in", on Vectoria's dark navy with the Vectoria logo. The card draws the mark with itsclass="interior"shapes removed, so the navy shows through the slits, the doorway and the floor.Checks
class="interior"shapes removed, the test colour shows through all four slits and the doorway.python scripts/build.pyputscastlegate_server/icon.pngin the plugin zip.python -m unittest discover -s tests/core -t .andpython -m unittest discover -s tests/plugin -t .pass.🤖 Generated with Claude Code
https://claude.ai/code/session_0125SG3UAHYDLELQvrNCq7Cv