Repository navigation
spec: Phase 32, the Phase 30 and 31 follow-ups - #254
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planning artifact for Phase 32 (v2.5), which clears the follow-ups Phases 30 and 31 left open. No code: docs/specs/PHASE-32-SPEC.md plus the VISION entry.
The thesis: five of the seven open follow-ups are quiet false passes, where
canvas_evaluatesays READY on a screen that is wrong. Each was reproduced on master. Reproducing them found more than the follow-up lines said. Contrast and spacing never look inside a component instance, so 1.14:1 text inside one passes. Seeded dark tints anddangersurvive a light preset.selectdraws its border in$borderat 1.46:1, and no check measures it. Before the fixes, the 140 tests that sit loose in the repo root move into folders that set their tier, so every later slice lands its tests in the new layout.Slices
A. Tests in folders.
test/unit,test/browser,test/e2eandtest/manualset the tier, which replaces the text-matching Chrome markers in the runner. Unit tests run with both Chrome path variables pointed at a missing binary, so a unit test that launches Chrome fails and the runner says it belongs intest/browser. Tests are type-checked understrictfor the first time, which means fixing 54 errors in 21 files. Files named by phase or issue are renamed by subject.B. One tree. Instances are expanded and resolved once, and the renderer and every rule read that tree. A disabled control inside a component now dims, and contrast, spacing and cliché checks see inside components. A finding inside an instance keeps the instance as its
nodeIdand addsinnerNodeIdfor the node inside.C. Tokens. A new
unknown-tokenwarning fires on any$refthe merged tokens do not define or that is the wrong kind for its prop. It autofixes only when one name is clearly nearest. Copy props such ascontentare never resolved, which fixes a renderer crash oncontent: "$body". Tints anddangerderive from the applied palette, on new stamps and on canvases that already hold the old seeds.D. Desktop-app checks.
selectdraws a$border-strongboundary and joins the boundary check. An activetree-rowdraws a bar that the indicator check measures. Stress widensnav-itemandtabscounts.E. Phone targets.
linkandtext-inputjoin the 44px phone check, andtext-inputgainssize: "lg"at 44px.modalandtoasttake acontrolSize, and the phone check measures their buttons.Decisions
Every fork in the spec's Clarify section is settled. Each one rests on evidence, on a precedent already in the code, or on Victor's call.
tree-rowgets an indicator bar (Victor). Contained tabs keep their filled segment, whose fill and heavier weight already mark the active tab. The docs say why they are not measured.dangerthat exactly equals its old seed is dropped before tokens merge, so it derives or inherits. A user who typed one of those six exact values by hand loses it.controlSize, withbutton's size names (Victor).sizealready means width onmodal, and atouch: trueflag could not express a height between 24 and 44.test-prefix (no problem to solve). Dropping it was cosmetic. The folders, the guard and the type check work either way, and dropping it would add a rename to all 140 files on top of the move.test/manual(follows from the folder rule). The folder sets the tier, so any other home for the two interactive tests would need an exception list again.unknown-tokenis a warning (precedent). An icon name that resolves to nothing is already a structure warning, and a token name that resolves to nothing is the same failure. A warning blocks presenting, which a typo must.selectout of the boundary check and gavetree-rowno indicator, as scope calls. The 1.46:1selectborder shows what that cost, and neither follow-up can be fixed without reversing them.The main risks, plainly
sha256r:hash and a recorded approval of it reads STALE. That is correct because its render changes, and the release notes have to say so.unknown-tokenfires on stored canvases. A canvas carrying a typo today gains a warning and stops being READY.CLAUDE.mdand.claude/are gitignored. Slice A updates their test paths locally, outside its PR.Verification
Two independent verifiers checked the first draft in parallel. One checked every code reference and reproduced the behaviour claims. The other checked the test-move facts and tried to break every pass/fail rule. A third verifier checked the revised draft. Every finding they raised is resolved in the text. Corrections included a test tsconfig that would have rejected every file and a Chrome guard that 15 browser tests bypassed. The verifiers also found an autofix example that could never fire, and a tint derivation that would have drawn light chips on dark pages.