Repository navigation
liteeditor: fix macOS crash on empty selection IME query - #1378
Merged
Merged
Conversation
Qt 6 QWidgetTextControl::inputMethodQuery calls deleteLater() on the QMimeData from createMimeDataFromSelection(). LiteEditorWidget returns null when nothing is selected, so macOS accessibility/Services queries crash with SIGSEGV at 0x8. Handle ImCurrentSelection in inputMethodQuery and return the selected text without going through createMimeDataFromSelection().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a macOS main-thread crash (
EXC_BAD_ACCESSat0x8) when Accessibility or the Services menu queries the focused editor with no text selected.Qt 6
QWidgetTextControl::inputMethodQuery(ImCurrentSelection)callscreateMimeDataFromSelection()and thendeleteLater()on the result.LiteEditorWidget::createMimeDataFromSelection()returns null when nothing is selected, so this becomesnull->deleteLater().Override
inputMethodQueryand return the current selection (including block selection) as text, so the Qt 6 null-pointer path is never taken. Copy still returns null fromcreateMimeDataFromSelection()when there is no selection.Test plan