Repository navigation
gopls: pass current file build tags via buildFlags - #1381
Merged
Merged
Conversation
Parse //go:build and // +build tags from the current Go file and send them to gopls as buildFlags so tagged package files get package metadata, completion, and navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//go:buildand// +buildtags from the current Go file and send them to gopls asbuildFlags(-tags=...).//go:build llgoand// +build ignoreare included in gopls package metadata.standaloneTagsdefaultignore, and reopen the current document after tag changes orno package metadata for file.Test plan
//go:build llgo.buildFlags: -tags=llgoand completion/navigation work.// +build ignoreand confirm it is recognized the same way.