fix: sanitize markup to prevent XSS - #2603
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hupf
reviewed
Sep 18, 2026
| }} | ||
| dangerouslySetInnerHTML={{ __html: layer.description }} | ||
| /> | ||
| <CustomLayerDescription description={layer.description} /> |
Contributor
There was a problem hiding this comment.
@mburri That fixes the XSS issue, but it also breaks every formatting markup. Shouldn't we sanitize the description instead, like we did in other places? Or was there a decision, that no formatting is allowed here?
If formatting should still work, I'd introduce a sanitizing component, maybe leveraging the already present sanitizeSchema/rehypeSanitize? Otherwise DOMPurify would be the goto IMO.
Also, I assume there is another XSS in app/rdf/query-search.ts with the highlightedTitle and highlightedDescription.
hupf
force-pushed
the
fix/security-issues
branch
from
September 18, 2026 12:49
b1badf7 to
48ef155
Compare
mburri
force-pushed
the
fix/security-issues
branch
from
October 5, 2026 09:20
7ebf250 to
318735c
Compare
hupf
force-pushed
the
fix/security-issues
branch
from
October 5, 2026 11:07
318735c to
555b1b0
Compare
hupf
force-pushed
the
fix/security-issues
branch
from
October 5, 2026 11:09
555b1b0 to
bb54735
Compare
hupf
approved these changes
Oct 5, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes some possible xxs vulnerabilties
see https://gitlab.lindas.admin.ch/bafu/bafu-visualize/visualize/-/work_items/787 for more details and how to reproduce